- Notifications
You must be signed in to change notification settings - Fork35
fix: add terminal window validation and configurable persistence#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
alvarosevilla95 wants to merge2 commits intocoder:mainChoose a base branch fromalvarosevilla95:fix/terminal-window-validation
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix: add terminal window validation and configurable persistence#60
alvarosevilla95 wants to merge2 commits intocoder:mainfromalvarosevilla95:fix/terminal-window-validation
+25 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds validation to check if the terminal window is still valid beforeattempting to focus it. If the window was closed, reopens the terminalinstead of throwing an error.This prevents crashes when the terminal window is manually closed andthe user tries to toggle focus.
Adds preserve_on_close option to terminal configuration that allows usersto preserve terminal processes when windows are manually closed. Defaultsto false for backward compatibility.- Add preserve_on_close config option (default: false)- Update native provider to use configurable buffer behavior- Fix hide_terminal to preserve process during programmatic hiding- Update README with new configuration option and documentationThis provides the same functionality as the snacks provider fix but makesit configurable so users can choose their preferred behavior.
e942ac9
to8101128
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Fixes terminal window validation issues and adds configurable terminal persistence.
Changes Made
Window Validation Fix (Snacks Provider)
Configurable Terminal Persistence (Native Provider)
preserve_on_close
configuration option (default:false
)true
, preserves terminal process when window is manually closed (native provider only)Configuration
Users can now enable terminal persistence by setting:
Default behavior (
preserve_on_close = false
): Terminal buffer is wiped when window is closed (original behavior)New behavior (
preserve_on_close = true
): Terminal buffer is hidden when window is closed, preserving the process for later restorationTechnical Details
preserve_on_close
setting only affects manual window closing (X button,:q
, etc.)