forked fromveracode/example-python
- Notifications
You must be signed in to change notification settings - Fork1
Patched results for branch: master#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
patched-codes wants to merge2 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
95076d0 to437c15bCompare437c15b to270fa50Compare270fa50 to6a2a0ebCompareThis pull request addresses two issues by fixing a command injection vulnerability in main.py through user input sanitization with shlex.quote() and enhancing security in html.js by encoding the kitId with encodeURIComponent() to prevent cross-site scripting attacks. Other changes in html.js are related to formatting and do not affect functionality.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This pull request from patched fixes 2 issues.
Fixed command injection vulnerability
The diff shows that a security vulnerability, specifically a command injection vulnerability, has been fixed. The user input is now being sanitized using the shlex.quote() function before being used in a command. This prevents malicious user input from being executed as part of the command.Refactoring and improving security of script loading
The diff shows that the script loading code has been refactored for better readability and security. The changes include the addition of encodeURIComponent() function to the kitId when forming the script source URL, which can prevent potential cross-site scripting (XSS) attacks by ensuring the kitId is properly encoded. The rest of the changes are mainly formatting and do not alter the functionality of the code.