Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

For Windows OS, revert the usage of cmd.exe by default (new option)#110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
axel3rd wants to merge1 commit intocodehaus-plexus:master
base:master
Choose a base branch
Loading
fromaxel3rd:update-42-For_Windows_revert_usage_of_cmd_by_default

Conversation

@axel3rd
Copy link
Contributor

@axel3rdaxel3rd commentedDec 21, 2020
edited
Loading

This PR is an update of old previous staling PR#42


cf.#17 (comments from May 2018): Revert the usage ofcmd.exe by default (on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.

Allow this behavior by the usage of a new method:

Commandline cmd = new Commandline();cmd.setForceShellOsSpecific( true );

This PR should be chosen or#109.

@axel3rdaxel3rd marked this pull request as draftDecember 21, 2020 11:29
@axel3rdaxel3rdforce-pushed theupdate-42-For_Windows_revert_usage_of_cmd_by_default branch fromc7a10b4 to84109d4CompareDecember 21, 2020 11:34
@axel3rdaxel3rdforce-pushed theupdate-42-For_Windows_revert_usage_of_cmd_by_default branch 3 times, most recently from8f20b85 to971980dCompareDecember 21, 2020 13:24
@axel3rdaxel3rdforce-pushed theupdate-42-For_Windows_revert_usage_of_cmd_by_default branch from971980d toff8e0e4CompareDecember 21, 2020 13:28
@axel3rd
Copy link
ContributorAuthor

Note: GitHub action verify problem with Java 16-ea is not part of this PR.

@axel3rdaxel3rd marked this pull request as ready for reviewDecember 21, 2020 13:35
@axel3rd
Copy link
ContributorAuthor

(@michael-o: Requested changes have been done)

@axel3rd
Copy link
ContributorAuthor

Note: GitHub action verify problem with Java 16-ea is not part of this PR.

See#116

@axel3rd
Copy link
ContributorAuthor

Is this PR (or#109) not relevant 😢 ?

@michael-o
Copy link
Member

I will try to pick this up next month.

axel3rd reacted with heart emoji

@axel3rd
Copy link
ContributorAuthor

Thank you !

@axel3rd
Copy link
ContributorAuthor

I will try to pick this up next month.

😁 (#FriendlyBump)

@michael-o
Copy link
Member

Thanks for the note. I think both Bourne Shell and Cmd Shell must go. There is no use for that.

@axel3rd
Copy link
ContributorAuthor

I think both Bourne Shell and Cmd Shell must go. There is no use for that

=> We abandon this PR, and perhaps#109 depending the relevance ?

@michael-o
Copy link
Member

I first need to understand why this was done at all. Maybe lack of knowledge. Currently, I don't see a reason why we should wrap these command into a shell execution at all.

axel3rd reacted with thumbs up emoji

@rfscholte
Copy link
Member

From what I've always understood only with a new shell you can isolate system properties and environment variables.

@michael-o
Copy link
Member

System properties are pure args to a process. There is no connection to the parent process. If want to isolate env vars, you can do that easily with the ProcessBuilder. It works just fine. Moreover, you cannot start with a nude environment because some processes expect default env vars and they won't be present. Just set those you need and that's it.

@michael-omichael-o removed their request for reviewOctober 23, 2022 08:59
@slachiewiczslachiewicz marked this pull request as draftJanuary 5, 2025 10:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@michael-omichael-omichael-o requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axel3rd@michael-o@rfscholte

[8]ページ先頭

©2009-2025 Movatter.jp