- Notifications
You must be signed in to change notification settings - Fork44
Revert usage of cmd on Windows#109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
axel3rd wants to merge1 commit intocodehaus-plexus:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Revert usage of cmd on Windows#109
axel3rd wants to merge1 commit intocodehaus-plexus:masterfromaxel3rd:update-41-Revert_usage_of_cmd_on_Windows
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
965bed7 to6168f2bComparemichael-o requested changesDec 21, 2020
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6168f2b to5f9a5ecCompareNote: GitHub action verify problem with Java 16-ea is not part of this PR. |
(@michael-o: Requested changes have been done) |
See#116 |
Is this PR (or#110) not relevant 😢 ? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR is an update of old previous staling PR#41
cf.#17 (comments from May 2018): Revert the usage of
cmd.exe(on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.For history: This Windows shell specific is removed sinceplexus-utils 3.0.15, except for 3.1.0.
On Windows, the usage ofcmd builtin (like
echo) or.cmd/.batonPATH should be implemented by the client/user.Another approach could be a dedicated option: See#110