- Notifications
You must be signed in to change notification settings - Fork24
feat: Add gitops environments resource#170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ilia-medvedev-codefresh commentedSep 8, 2025
/test |
ilia-medvedev-codefresh commentedSep 8, 2025
/test |
eti-codefresh commentedSep 8, 2025
i reviewed the platform side looks good to me |
scme0 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
| "server": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Target cluster server url. Defaults to `https://kubernetes.default.svc` which is the default in-cluster url", | ||
| Default: "https://kubernetes.default.svc", | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
server should always correspond to the server of ArgoCD cluster we put inname and we don't have any validation for it on the backend. Putting random address inserver can result in weird bug when in our UI we see that environment configured with cluster X, but inside it has apps from cluster Y.
What I think we should do is to remove "server" from graphql mutation input and derive it from the DB according to the provided cluster name. It should be easy change on backend side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@denis-codefresh I agree. I did the implementation according to the current schema and it's a mandatory field
What
Why
Notes
Checklist
/testcomment will be ignored by the CI triggerunless it is made by a repo admin or collaborator.