Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Claude.md#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
aseembits93 wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromclaudemd
Draft

Claude.md#619

aseembits93 wants to merge3 commits intomainfromclaudemd

Conversation

@aseembits93
Copy link
Contributor

@aseembits93aseembits93 commentedAug 6, 2025
edited by github-actionsbot
Loading

PR Type

Documentation


Description

  • AddClaude.md with linting and formatting commands

  • Includeruff andmypy instructions for code checks

  • Add placeholder Code style section

  • Add workflow tips: typecheck and focused tests


File Walkthrough

Relevant files
Documentation
Claude.md
Create Claude.md linting and workflow guide                           

Claude.md

  • Added Bash commands section for linting and formatting
  • Includedruff check --fix andruff format commands
  • Addedmypy typechecking instructions
  • Added workflow guidelines for code checks and tests
+12/-0   

@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incomplete Command

Themypy command line ends with a hyphen and may be truncated. Ensure the full invocation and any allowlist file are specified correctly.

- mypy --non-interactive --config-file pyproject.toml @mypy_allowlist.txt: mypy typechecker-
Empty Section

The Code style section is left blank. Add the intended style guidelines or remove the placeholder to avoid confusion.

#Code style--

@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Comment on lines +1 to +7
# Bash commands
- `ruff check --fix --exit-non-zero-on-fix --config=pyproject.toml .`: Run the linter
- `ruff format .`: Run the formatter
- `mypy --non-interactive --config-file pyproject.toml @mypy_allowlist.txt`: mypy typechecker

# Running tests
- Run tests with `pytest tests/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

these will all fail because we're using uv in order to run these commands, maybe using hooks is a better approachhttps://docs.anthropic.com/en/docs/claude-code/hooks-guide

@aseembits93aseembits93 marked this pull request as draftOctober 28, 2025 20:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@KRRT7KRRT7KRRT7 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aseembits93@KRRT7

[8]ページ先頭

©2009-2025 Movatter.jp