Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support for date partitioned logging keys#282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
NathanBaulch wants to merge4 commits intocloudposse:main
base:main
Choose a base branch
Loading
fromNathanBaulch:partition_date

Conversation

@NathanBaulch
Copy link

what

A couple of years ago AWS introduced the option to format S3 access log keys by forward slash instead of hyphen "to speed up analytics and query applications" (quote from AWS Console).

This requires bumping the AWS provider to v5.27. I'm not sure about the wider implications of that.

why

I'd like to access this feature in my IaC scripts.

references

https://registry.terraform.io/providers/hashicorp/aws/5.27.0/docs/resources/s3_bucket_logging#target_object_key_format

@NathanBaulchNathanBaulch requested review froma team ascode ownersOctober 28, 2025 00:49
@mergifymergifybot added the triageNeeds triage labelOct 28, 2025
Copy link
Member

@joe-nilandjoe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good@NathanBaulch, thanks for this.
Could you please also runmake readme to update the docs?

@NathanBaulch
Copy link
Author

Looks likeMakefile was replaced withatmos.yaml ~5 months ago. I have no experience with Atmos.

@joe-niland
Copy link
Member

Looks likeMakefile was replaced withatmos.yaml ~5 months ago. I have no experience with Atmos.

Ah ok - that's news to me also. I'll look into it.

@joe-niland
Copy link
Member

Looks likeMakefile was replaced withatmos.yaml ~5 months ago. I have no experience with Atmos.

So it was just (on a mac):

brew install atmosatmos readme

https://atmos.tools/install for other platforms.

I've rebuilt the readme.

Please check the linting error:https://github.com/cloudposse/terraform-aws-s3-bucket/actions/runs/18861770411/job/53821423651?pr=282

NathanBaulch reacted with thumbs up emoji

@NathanBaulch
Copy link
Author

Might be worth documenting the accepted values forobject_key_partition_date somewhere - either empty (meaning use the simple format) orEventTime orDeliveryTime (for "partitioned" format). Or even better use a validation. I wasn't sure where to add this given it's a nested field.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@joe-nilandjoe-nilandjoe-niland left review comments

@GowiemGowiemAwaiting requested review from GowiemGowiem is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

triageNeeds triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanBaulch@joe-niland
[8]ページ先頭
©2009-2025 Movatter.jp