Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minimal provider version for aws_s3_directory_bucket#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
salemgolemugoo wants to merge2 commits intocloudposse:main
base:main
Choose a base branch
Loading
fromsalemgolemugoo:patch-1

Conversation

@salemgolemugoo
Copy link

@salemgolemugoosalemgolemugoo commentedDec 11, 2024
edited
Loading

what

Updated AWS provider version for the new resource used in the module aws_s3_directory_bucket

why

Old provider doesn't support this resourceThe provider hashicorp/aws does not support resource type

references

https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5280-november-29-2023

@nitrocode
Copy link
Member

/terratest

github-actions[bot] reacted with thumbs up emoji

@nitrocode
Copy link
Member

@Gowiem this would require a major version, right? If so, then we'd probably need to add all the non major changes first before this goes in

@Gowiem
Copy link
Member

@nitrocode I think we are treating major provider version bumps as major module version bumps, so that sounds right 👍

@GowiemGowiem added enhancementNew feature or request majorBreaking changes (or first stable release) labelsJun 2, 2025
@Gowiem
Copy link
Member

Oh but@salemgolemugoo is saying that we're already usingaws_s3_directory_bucket (which we are) and that resources REQUIRES v5.x of the AWS Provider... so we should've already did a major rev when we introduced that resource... damn.

@nitrocode I feel like it probably makes sense to raise this as a major rev and update all of the release docs from when that resource was added to mention that it should've included this provider rev to major. Mind taking that on?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@johncblandiijohncblandiiAwaiting requested review from johncblandiijohncblandii is a code owner automatically assigned from cloudposse/contributors

@joe-nilandjoe-nilandAwaiting requested review from joe-nilandjoe-niland is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancementNew feature or requestmajorBreaking changes (or first stable release)triageNeeds triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@salemgolemugoo@nitrocode@Gowiem

[8]ページ先頭

©2009-2025 Movatter.jp