Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Choose a tag to compare

@cloudpossebotcloudpossebot released this 25 Nov 19:07
aa12287
This commit was created on GitHub.com and signed with GitHub’sverified signature. The key has expired.
GPG key ID:4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

🐛 Bug Fixes

Fix: fix incorrect conditional logic for dynamic blocks iterating on `var.ec2_tag_set` and `var.ec2_tag_filter`@StephenTan-TW (#13)

what

Original PR description:

In order to ensure that tagging is processed correctly, I have created a PR of working code.
For some reason, we need to disable conditionals for ec2_tag_filter variable and we need to set the following conditional for ec2_tag_set:var.ec2_tag_set == null ? [] : [var.ec2_tag_set]
Note that I have had to do a huge rebase when pulling the upstream code. No idea what is going on.

  • Swap second and third arguments in ternary operator forvar.ec2_tag_set andvar.ec2_tag_filter, which are incorrectly supplying an empty list if their lengths are > 0.
  • Uselookup function in dynamic blocks in order to introduce more robustness.

why

  • Ifvar.ec2_tag_set andvar.ec2_tag_filter are supplied as non-empty lists, theec2_tag_filter blocks will not be populated, since the ternary operator will evaluate to empty lists, and hence the dynamic block will produce no such blocks.

Contributors

  • @StephenTan-TW
StephenTan-TW
Assets2
Loading

[8]ページ先頭

©2009-2025 Movatter.jp