Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update protocols.adoc#654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ieugen wants to merge2 commits intoclojure:master
base:master
Choose a base branch
Loading
fromieugen:patch-2
Open

Conversation

ieugen
Copy link

Made surethis is mentioned as first argument.
It's not obvious from the docs.

  • Have you read theguidelines for contributing?
  • Have you signed the Clojure Contributor Agreement?
  • Have you verified your asciidoc markup is correct?

Signed CA on 2022-11-16 .

Made sure `this` is mentioned as first argument.It's not obvious from the docs.
@seancorfield
Copy link
Member

Because you've added an extra argument, the example calls are no longer correct.

Perhaps renaming the current first argument tothis would be a safer change? (although that would make the argument lists bethis b andthis b c which is less intuitive in my opinion)

@ieugen
Copy link
Author

I can prepend this and drop the last argument.

@ieugen
Copy link
Author

@seancorfield : If it's still not good, please feel free to update it so it is fine.

@seancorfield
Copy link
Member

The protocolP /bar-me code is still incorrect because you've added an argument there.

I'll leave it up to@puredanger et al to decide what clarifications actually work / are needed here.

@puredanger
Copy link
Member

There are a couple of existing issues,#215 and#216, that I think also have some excellent points and examples. I think the most important thing to change about the examples here is to make the examples actually meaningful, and not use foo/bar/baz at all. Or maybe it's syntax + examples or something.

My one hesitation with makingthis more prevalent (even though this is a common usage), is that it implies extra meaning for developers coming from Java (where that is a special thing), and also the anaphoric macroproxy wherethis actually is a "special" bound symbol. But maybe it's just a matter of saying that explicitly in the doc.

@ieugen
Copy link
Author

I think keepingthis (for a lack of better name) + explicit mentioning behavior in the docs is good enough.
I could try to merge the docs.
@puredanger: please let me know if you want to take this on or not.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ieugen@seancorfield@puredanger

[8]ページ先頭

©2009-2025 Movatter.jp