- Notifications
You must be signed in to change notification settings - Fork271
Update protocols.adoc#654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Made sure `this` is mentioned as first argument.It's not obvious from the docs.
Because you've added an extra argument, the example calls are no longer correct. Perhaps renaming the current first argument to |
I can prepend this and drop the last argument. |
@seancorfield : If it's still not good, please feel free to update it so it is fine. |
The protocol I'll leave it up to@puredanger et al to decide what clarifications actually work / are needed here. |
There are a couple of existing issues,#215 and#216, that I think also have some excellent points and examples. I think the most important thing to change about the examples here is to make the examples actually meaningful, and not use foo/bar/baz at all. Or maybe it's syntax + examples or something. My one hesitation with making |
I think keeping |
Made sure
this
is mentioned as first argument.It's not obvious from the docs.
Signed CA on 2022-11-16 .