- Notifications
You must be signed in to change notification settings - Fork66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove api_generated_docs_enabled flag#9954
Draft
gwendolyngoetz wants to merge1 commit intomainChoose a base branch fromgwen/rm-generated_docs_flag
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #9954 +/- ##============================================+ Coverage 82.56% 83.33% +0.76%+ Complexity 4390 4389 -1============================================ Files 508 521 +13 Lines 19541 21254 +1713 Branches 1281 1280 -1 ============================================+ Hits 16135 17713 +1578- Misses 2904 3042 +138+ Partials 502 499 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0fb91e5
to6662124
Compare6662124
to865e7b8
Compare865e7b8
tof471415
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always show API docs tab. If you have
API_GENERATED_DOCS_ENABLED
in your deployment config file it should be removed.Checklist
General
Read the full guidelines for PRshere
civiform/developers
, or amore specific round-robin listFixes#9936