- Notifications
You must be signed in to change notification settings - Fork7
Added initial state functionality to modules.#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sebas5384 commentedJul 24, 2016
@lucasconstantino I think this PR is doing some refactors which could be in different PR in order to review it better. The code of which enables the initial state for modules is really great, and I think we can do it in a way it isn't close the door to Immutable libraries (for example ImmutableJS). Given that I think we can do PR which enables the developers toextend the @recidive and@lucasconstantino how we could do the initial state handled in way we don't loose compatibility with immutable libraries? |
6bf3367 to31c0fddCompare31c0fdd to602fbf4Comparesebas5384 commentedSep 3, 2016
@lucasconstantino I did PR over this issue, to avoid the mutation of state object passed as reference. |
Removed mutation of the state passed as reference.
lucasconstantino commentedSep 3, 2016
Done ;) |
sebas5384 commentedSep 3, 2016
@lucasconstantino awesome!! Oh! I think we forgot the documentation, so I'll document it and send you a PR later 👍 |
No description provided.