Commit43cff3a

odiszapc

authored and

slandelle

committed

Update progress during upload large bodies,closeAsyncHttpClient#728

Motivation:`BodyChunkedInput` does not update progress member, it always stays zero.Thus `ProgressAsyncHandler#onContentWriteProgress` receives zeroes in amount and current parameters. Users sees data is being sent but has no information about exact amount of data has been written to channel.Modifications:`BodyChunkedInput` was modified to update progress.`WriteProgressListener` was modified to ignore zero progress. It happens due to non-blocking nature of network writes. We just ignore callbacks when there was no progress at all.Result:Progress is updated each time bytes are phisically written to channel.Callbacks are triggered with actual amount of data written.

1 parent79016a7 commit43cff3aCopy full SHA for 43cff3a

File tree

2 files changed

-1

lines changed

client/src/main/java/org/asynchttpclient/netty/request
- WriteProgressListener.java
- body
  - BodyChunkedInput.java

2 files changed

-1

lines changed

`‎client/src/main/java/org/asynchttpclient/netty/request/WriteProgressListener.java‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,9 @@ public void operationProgressed(ChannelProgressiveFuture f, long progress, long`
`45`	`45`	`if (total <0) {`
`46`	`46`	`total =expectedTotal;`
`47`	`47`	`}`
`48`		`-progressAsyncHandler.onContentWriteProgress(progress -lastLastProgress,progress,total);`
	`48`	`+if (progress !=lastLastProgress) {`
	`49`	`+progressAsyncHandler.onContentWriteProgress(progress -lastLastProgress,progress,total);`
	`50`	`+ }`
`49`	`51`	`}`
`50`	`52`	`}`
`51`	`53`	`}`

`‎client/src/main/java/org/asynchttpclient/netty/request/body/BodyChunkedInput.java‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ public ByteBuf readChunk(ByteBufAllocator alloc) throws Exception {`
`57`	`57`
`58`	`58`	`ByteBufbuffer =alloc.buffer(chunkSize);`
`59`	`59`	`Body.BodyStatestate =body.transferTo(buffer);`
	`60`	`+progress +=buffer.writerIndex();`
`60`	`61`	`switch (state) {`
`61`	`62`	`caseSTOP:`
`62`	`63`	`endOfInput =true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit43cff3a

File tree

2 files changed

2 files changed

`‎client/src/main/java/org/asynchttpclient/netty/request/WriteProgressListener.java‎`

`‎client/src/main/java/org/asynchttpclient/netty/request/body/BodyChunkedInput.java‎`

0 commit comments