Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit25b0e9b

Browse files
committed
Drop NettyResponseFuture:: isAndSetStatusReceived,closeAsyncHttpClient#1349
Motivation:I’m not sure what this code was for. It’s been there for ages (2010,the git repository doesn’t have older commits, seehttps://github.com/AsyncHttpClient/async-http-client/blob/8c62f3ea9c647ab057f3d9d4d1fef5d76b52e8e8/src/main/java/com/ning/http/client/providers/netty/NettyResponseFuture.java#L65).I suspect this was used because of bugs that caused multiplesubmissions for the same request. Such bugs have been fixed since then.Let’s remove this dead code.Modifications:Remove `NettyResponseFuture:: isAndSetStatusReceived`.Result:Less dead code
1 parent821a0f7 commit25b0e9b

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

‎client/src/main/java/org/asynchttpclient/netty/NettyResponseFuture.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ public final class NettyResponseFuture<V> implements ListenableFuture<V> {
8080
@SuppressWarnings("rawtypes")
8181
privatestaticfinalAtomicIntegerFieldUpdater<NettyResponseFuture>inProxyAuthField =AtomicIntegerFieldUpdater.newUpdater(NettyResponseFuture.class,"inProxyAuth");
8282
@SuppressWarnings("rawtypes")
83-
privatestaticfinalAtomicIntegerFieldUpdater<NettyResponseFuture>statusReceivedField =AtomicIntegerFieldUpdater.newUpdater(NettyResponseFuture.class,"statusReceived");
84-
@SuppressWarnings("rawtypes")
8583
privatestaticfinalAtomicIntegerFieldUpdater<NettyResponseFuture>contentProcessedField =AtomicIntegerFieldUpdater.newUpdater(NettyResponseFuture.class,"contentProcessed");
8684
@SuppressWarnings("rawtypes")
8785
privatestaticfinalAtomicIntegerFieldUpdater<NettyResponseFuture>onThrowableCalledField =AtomicIntegerFieldUpdater.newUpdater(NettyResponseFuture.class,"onThrowableCalled");
@@ -360,10 +358,6 @@ public void setChannelState(ChannelState channelState) {
360358
this.channelState =channelState;
361359
}
362360

363-
publicbooleanisAndSetStatusReceived(booleansr) {
364-
returnstatusReceivedField.getAndSet(this,sr ?1 :0) !=0;
365-
}
366-
367361
publicbooleanisStreamConsumed() {
368362
returnstreamAlreadyConsumed;
369363
}

‎client/src/main/java/org/asynchttpclient/netty/handler/HttpHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ private boolean exitAfterHandlingStatus(//
8787
HttpResponseresponse,AsyncHandler<?>handler,//
8888
NettyResponseStatusstatus,//
8989
HttpRequesthttpRequest)throwsIOException,Exception {
90-
return!future.isAndSetStatusReceived(true) &&handler.onStatusReceived(status) !=State.CONTINUE;
90+
returnhandler.onStatusReceived(status) !=State.CONTINUE;
9191
}
9292

9393
privatebooleanexitAfterHandlingHeaders(//

‎client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,6 @@ public boolean retry(NettyResponseFuture<?> future) {
426426

427427
if (future.isReplayPossible()) {
428428
future.setChannelState(ChannelState.RECONNECTED);
429-
future.isAndSetStatusReceived(false);
430429

431430
LOGGER.debug("Trying to recover request {}\n",future.getNettyRequest().getHttpRequest());
432431
if (future.getAsyncHandler()instanceofAsyncHandlerExtensions) {

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp