Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit08dcc79

Browse files
committed
Remove AsyncHttpClientConfig parameter from HttpResponseStatus constructor,closeAsyncHttpClient#1340
Motivation:This parameter is never being used (remnant of AHC1).Modifications:Remove from `HttpResponseStatus` and `NettyResponseStatus` and`HttpStatusWrapper` descendants constructors.Result:Unused parameter dropped
1 parent3692a0c commit08dcc79

File tree

6 files changed

+9
-12
lines changed

6 files changed

+9
-12
lines changed

‎client/src/main/java/org/asynchttpclient/HttpResponseStatus.java‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@
2626
publicabstractclassHttpResponseStatus {
2727

2828
privatefinalUriuri;
29-
protectedfinalAsyncHttpClientConfigconfig;
3029

31-
publicHttpResponseStatus(Uriuri,AsyncHttpClientConfigconfig) {
30+
publicHttpResponseStatus(Uriuri) {
3231
this.uri =uri;
33-
this.config =config;
3432
}
3533

3634
/**

‎client/src/main/java/org/asynchttpclient/netty/NettyResponseStatus.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
importjava.net.SocketAddress;
2020

21-
importorg.asynchttpclient.AsyncHttpClientConfig;
2221
importorg.asynchttpclient.HttpResponseStatus;
2322
importorg.asynchttpclient.uri.Uri;
2423

@@ -31,8 +30,8 @@ public class NettyResponseStatus extends HttpResponseStatus {
3130
privatefinalSocketAddressremoteAddress;
3231
privatefinalSocketAddresslocalAddress;
3332

34-
publicNettyResponseStatus(Uriuri,AsyncHttpClientConfigconfig,HttpResponseresponse,Channelchannel) {
35-
super(uri,config);
33+
publicNettyResponseStatus(Uriuri,HttpResponseresponse,Channelchannel) {
34+
super(uri);
3635
this.response =response;
3736
if (channel !=null) {
3837
remoteAddress =channel.remoteAddress();

‎client/src/main/java/org/asynchttpclient/netty/handler/HttpHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ private void handleHttpResponse(final HttpResponse response, final Channel chann
125125

126126
future.setKeepAlive(config.getKeepAliveStrategy().keepAlive(future.getTargetRequest(),httpRequest,response));
127127

128-
NettyResponseStatusstatus =newNettyResponseStatus(future.getUri(),config,response,channel);
128+
NettyResponseStatusstatus =newNettyResponseStatus(future.getUri(),response,channel);
129129
HttpResponseHeadersresponseHeaders =newHttpResponseHeaders(response.headers());
130130

131131
if (!interceptors.exitAfterIntercept(channel,future,handler,response,status,responseHeaders)) {

‎client/src/main/java/org/asynchttpclient/netty/handler/WebSocketHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public void handleRead(Channel channel, NettyResponseFuture<?> future, Object e)
136136
}
137137

138138
WebSocketUpgradeHandlerhandler =WebSocketUpgradeHandler.class.cast(future.getAsyncHandler());
139-
HttpResponseStatusstatus =newNettyResponseStatus(future.getUri(),config,response,channel);
139+
HttpResponseStatusstatus =newNettyResponseStatus(future.getUri(),response,channel);
140140
HttpResponseHeadersresponseHeaders =newHttpResponseHeaders(response.headers());
141141

142142
if (!interceptors.exitAfterIntercept(channel,future,handler,response,status,responseHeaders)) {

‎client/src/main/java/org/asynchttpclient/webdav/WebDavCompletionHandlerBase.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ private class HttpStatusWrapper extends HttpResponseStatus {
151151
privatefinalintstatusCode;
152152

153153
publicHttpStatusWrapper(HttpResponseStatuswrapper,StringstatusText,intstatusCode) {
154-
super(wrapper.getUri(),null);
154+
super(wrapper.getUri());
155155
this.wrapped =wrapper;
156156
this.statusText =statusText;
157157
this.statusCode =statusCode;

‎client/src/test/java/org/asynchttpclient/netty/NettyAsyncResponseTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public void testCookieParseExpires() {
3838
finalStringcookieDef =String.format("efmembercheck=true; expires=%s; path=/; domain=.eclipse.org",sdf.format(date));
3939

4040
HttpResponseHeadersresponseHeaders =newHttpResponseHeaders(newDefaultHttpHeaders().add(SET_COOKIE,cookieDef));
41-
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null,null),responseHeaders,null);
41+
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null),responseHeaders,null);
4242

4343
List<Cookie>cookies =response.getCookies();
4444
assertEquals(cookies.size(),1);
@@ -52,7 +52,7 @@ public void testCookieParseMaxAge() {
5252
finalStringcookieDef ="efmembercheck=true; max-age=60; path=/; domain=.eclipse.org";
5353

5454
HttpResponseHeadersresponseHeaders =newHttpResponseHeaders(newDefaultHttpHeaders().add(SET_COOKIE,cookieDef));
55-
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null,null),responseHeaders,null);
55+
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null),responseHeaders,null);
5656
List<Cookie>cookies =response.getCookies();
5757
assertEquals(cookies.size(),1);
5858

@@ -64,7 +64,7 @@ public void testCookieParseMaxAge() {
6464
publicvoidtestCookieParseWeirdExpiresValue() {
6565
finalStringcookieDef ="efmembercheck=true; expires=60; path=/; domain=.eclipse.org";
6666
HttpResponseHeadersresponseHeaders =newHttpResponseHeaders(newDefaultHttpHeaders().add(SET_COOKIE,cookieDef));
67-
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null,null),responseHeaders,null);
67+
NettyResponseresponse =newNettyResponse(newNettyResponseStatus(null,null,null),responseHeaders,null);
6868

6969
List<Cookie>cookies =response.getCookies();
7070
assertEquals(cookies.size(),1);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp