- Notifications
You must be signed in to change notification settings - Fork7
Ninja makefile fallback#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
shirakaba commentedJun 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Does the fact that Chromium isdropping Ninja in favour of Siso have any impact on this? |
Using Ninja by default is just to get the fastest builds possible and CMake doesn't support Siso: This suggested change is just a simple way to degrade gracefully, in case the Ninja is not installed, to not force library authors into using Ninja - if they absolutely doesn't want to install it. |
90dd405 to8dac805Compare
Thisfixes#95 by adding a check and a fallback to Unix Makefiles.
Currently in draft because it building
weak-node-apifails when the fallback is used: