Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ninja makefile fallback#108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
kraenhansen wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromkh/ninja-makefile-fallback

Conversation

@kraenhansen
Copy link
Collaborator

Thisfixes#95 by adding a check and a fallback to Unix Makefiles.

Currently in draft because it buildingweak-node-api fails when the fallback is used:

image

@kraenhansenkraenhansen self-assigned thisMay 22, 2025
@kraenhansenkraenhansen added the enhancementNew feature or request labelMay 22, 2025
@changeset-bot
Copy link

⚠️ No Changeset found

Latest commit:aba1cde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shirakaba
Copy link
Collaborator

shirakaba commentedJun 21, 2025
edited
Loading

Does the fact that Chromium isdropping Ninja in favour of Siso have any impact on this?

@kraenhansen
Copy link
CollaboratorAuthor

Does the fact that Chromium isdropping Ninja in favour of Siso have any impact on this?
Likely not.

Using Ninja by default is just to get the fastest builds possible and CMake doesn't support Siso:
https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html#command-line-build-tool-generators

This suggested change is just a simple way to degrade gracefully, in case the Ninja is not installed, to not force library authors into using Ninja - if they absolutely doesn't want to install it.

shirakaba reacted with thumbs up emoji

@kraenhansenkraenhansenforce-pushed themain branch 4 times, most recently from90dd405 to8dac805CompareJuly 7, 2025 12:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@kraenhansenkraenhansen

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build-weak-node-api requires Ninja

3 participants

@kraenhansen@shirakaba

[8]ページ先頭

©2009-2025 Movatter.jp