- Notifications
You must be signed in to change notification settings - Fork190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
sso_*: move sign_in and sign_out HTML pages to sso_proxy#261
Open
Jusshersmith wants to merge5 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
template pkgadd static_files_test.go filefix TestSecurityHeaders testfix TestOAuthStart: replace template interfacefix TestHTTPSRedirectpartial but incomplete fix for test_provider GetSignInURL/GetSignOutURLadd initial TestSignOutPage functionfix sign out with no session workflowsome tidyingssso_auth:additional redirect URI changessso_auth: authenticagtor test changessso_proxy: oauthproxy tests
1a8eeb6 tod6843c3CompareCodecov Report
@@ Coverage Diff @@## master #261 +/- ##=========================================- Coverage 62.51% 62.5% -0.02%========================================= Files 54 55 +1 Lines 4199 4211 +12 =========================================+ Hits 2625 2632 +7- Misses 1385 1386 +1- Partials 189 193 +4
|
Marked as ready for review, but see Notes in description. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current setup of html sign in and sign out pages causes some extra friction with implementing#252 - this change gives us some extra flexibility here. Also, having
sso_proxyfirst send requests tosso_auth, which subsequently renders the sign in page (and redirects back) results in extra requests and extra complexity (for example, an extra layer of nested redirects needs to be specified).Solution
Move the sign_in and sign_out HTML pages to be rendered by sso_proxy instead of sso_auth. In doing so, simplify the flow in part between
sso_proxyandsso_authenticator.Notes
This is a big change, so I'm working to add some more detailed descriptions of the changes (and going over any TODO's) to aid in better understanding them, as well as reviewing the PR in general.