- Notifications
You must be signed in to change notification settings - Fork190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Extend timeouts#181
base:main
Are you sure you want to change the base?
Extend timeouts#181
Conversation
| @@ -185,8 +185,8 @@ func (t *upstreamTransport) getTransport() *http.Transport { | |||
| t.transport = &http.Transport{ | |||
| Proxy: http.ProxyFromEnvironment, | |||
| DialContext: (&net.Dialer{ | |||
| Timeout: 30 * time.Second, | |||
| KeepAlive: 30 * time.Second, | |||
| Timeout: 300 * time.Second, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should figure out a way to make this configurable. A default of 300 seconds (much like 30 seconds) is unlikely to be sufficient for everyone's needs.
| @@ -216,6 +216,7 @@ func NewReverseProxy(to *url.URL, config *UpstreamConfig) *httputil.ReverseProxy | |||
| req.Host = to.Host | |||
| } | |||
| } | |||
| proxy.FlushInterval = 100 * time.Millisecond | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think we should supply this default since this is configurable per upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That can be dropped, yeah.
We're using SSO proxy to sit in the middle of another auth component that blocks waiting for authentication to complete. We need a long timeout to allow the user to finish the authentication flow that SSO is mediating. The timeout needs to at least get us past p99 time-to-complete-authentication and 5 minutes seems to be approximately the sweet spot.