NotificationsYou must be signed in to change notification settings
Fork252
Star2.7k

Commit83ca33e

committed

Yield from import module discovery

Avoid interruptions by yielding more frequently.This prevent unresponsiveness while working throughportions of directory trees without any Python modules.

1 parenta9db837 commit83ca33eCopy full SHA for 83ca33e

File tree

1 file changed

-3

lines changed

bpython
- importcompletion.py

1 file changed

-3

lines changed

`‎bpython/importcompletion.py‎`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,9 @@ def complete(self, cursor_offset: int, line: str) -> Optional[Set[str]]:`
`155`	`155`	`else:`
`156`	`156`	`returnNone`
`157`	`157`
`158`		`-deffind_modules(self,path:Path)->Generator[str,None,None]:`
	`158`	`+deffind_modules(`
	`159`	`+self,path:Path`
	`160`	`+ )->Generator[Union[str,None],None,None]:`
`159`	`161`	`"""Find all modules (and packages) for a given directory."""`
`160`	`162`	`ifnotpath.is_dir():`
`161`	`163`	`# Perhaps a zip file`
`@@ -219,9 +221,12 @@ def find_modules(self, path: Path) -> Generator[str, None, None]:`
`219`	`221`	`if (stat.st_dev,stat.st_ino)notinself.paths:`
`220`	`222`	`self.paths.add((stat.st_dev,stat.st_ino))`
`221`	`223`	`forsubnameinself.find_modules(path_real):`
`222`		`-ifsubname!="__init__":`
	`224`	`+ifsubnameisNone:`
	`225`	`+yieldNone# take a break to avoid unresponsiveness`
	`226`	`+elifsubname!="__init__":`
`223`	`227`	`yieldf"{name}.{subname}"`
`224`	`228`	`yieldname`
	`229`	`+yieldNone# take a break to avoid unresponsiveness`
`225`	`230`
`226`	`231`	`deffind_all_modules(`
`227`	`232`	`self,paths:Iterable[Path]`
`@@ -231,7 +236,8 @@ def find_all_modules(`
`231`	`236`
`232`	`237`	`forpinpaths:`
`233`	`238`	`formoduleinself.find_modules(p):`
`234`		`-self.modules.add(module)`
	`239`	`+ifmoduleisnotNone:`
	`240`	`+self.modules.add(module)`
`235`	`241`	`yield`
`236`	`242`
`237`	`243`	`deffind_coroutine(self)->Optional[bool]:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit83ca33e

File tree

1 file changed

1 file changed

`‎bpython/importcompletion.py‎`

0 commit comments