Commit1bc255b

committed

Directly access class methods in introspection (fixes#966)

inspect.signature is unable to process classmethod instances. So wedirectly access the member via its __get__.

1 parent1332d18 commit1bc255bCopy full SHA for 1bc255b

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,9 @@ def getattr_safe(obj: Any, name: str) -> Any:`
`358`	`358`	`# Slots are a MemberDescriptorType`
`359`	`359`	`ifisinstance(result,MemberDescriptorType):`
`360`	`360`	`result=getattr(obj,name)`
	`361`	`+# classmethods are safe to access (see #966)`
	`362`	`+ifisinstance(result,classmethod):`
	`363`	`+result=result.__get__(obj,obj)`
`361`	`364`	`returnresult`
`362`	`365`
`363`	`366`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,6 @@ def fun_annotations(number: int, lst: List[int] = []) -> List[int]:`
`180`	`180`	`self.assertEqual(props.argspec.args, ["number","lst"])`
`181`	`181`	`self.assertEqual(props.argspec.defaults[0], [])`
`182`	`182`
`183`		`-@unittest.expectedFailure`
`184`	`183`	`deftest_issue_966_class_method(self):`
`185`	`184`	`classIssue966(Sequence):`
`186`	`185`	`@classmethod`

Comments

(0)