Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-table): fix sorting for negative numeric string#7134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(b-table): fix sorting for negative numeric string#7134
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedMar 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
codesandbox-cibot commentedMar 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. |
b095b36 to22e670dComparejongwoo328 commentedMar 26, 2025
@jacobmllr95 |
codecovbot commentedMar 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## dev #7134 +/- ##======================================= Coverage 99.96% 99.96% ======================================= Files 305 305 Lines 11206 11206 Branches 2647 2647 ======================================= Hits 11202 11202 Misses 4 4
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
46360a7 intobootstrap-vue:devUh oh!
There was an error while loading.Please reload this page.
Describe the PR
Fixed the sorting logic for negative numeric string in b-table.
Current sorting does not perform the correct sort if data contains
-at the beginning of string.Because when sorting with the
numeric: trueoption, it is consistent that the negative string is also sorted as if it were negative number.Seehttps://jsfiddle.net/pudding_dev/506vbgon/3/
If you sort this table ascending order, result should be like [-100, -20, -10, -5, -1, 1, 5].
However, In current version, it's like [-1, -5, -10, -20, -100, 1, 5].
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: