Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-table): fix sorting for negative numeric string#7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@jongwoo328
Copy link
Contributor

Describe the PR

Fixed the sorting logic for negative numeric string in b-table.
Current sorting does not perform the correct sort if data contains- at the beginning of string.
Because when sorting with thenumeric: true option, it is consistent that the negative string is also sorted as if it were negative number.

Seehttps://jsfiddle.net/pudding_dev/506vbgon/3/
If you sort this table ascending order, result should be like [-100, -20, -10, -5, -1, 1, 5].
However, In current version, it's like [-1, -5, -10, -20, -100, 1, 5].

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

hyejungg and ohdnf reacted with thumbs up emoji
@vercel
Copy link

vercelbot commentedMar 16, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated
bootstrap-vue✅ Ready (Inspect)Visit Preview💬Add your feedbackMar 16, 2023 at 5:24PM (UTC)

@codesandbox-ci
Copy link

codesandbox-cibot commentedMar 16, 2023
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

@jongwoo328jongwoo328force-pushed thesorting-negative-numeric-string branch fromb095b36 to22e670dCompareMarch 26, 2025 07:43
@jongwoo328
Copy link
ContributorAuthor

@jacobmllr95
This branch is up-to-date. thanks!

@codecov
Copy link

codecovbot commentedMar 26, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base(fd586c0) to head(22e670d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@##              dev    #7134   +/-   ##=======================================  Coverage   99.96%   99.96%           =======================================  Files         305      305             Lines       11206    11206             Branches     2647     2647           =======================================  Hits        11202    11202             Misses          4        4
FlagCoverage Δ
unittests99.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobmllr95jacobmllr95 merged commit46360a7 intobootstrap-vue:devMar 26, 2025
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jongwoo328@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp