Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.2k
Fix default formatter in ColorBar and update related test. Fix issue (bug ) #12618#14553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
shashank1225 wants to merge1 commit intobokeh:branch-3.9Choose a base branch
base:branch-3.9
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix default formatter in ColorBar and update related test. Fix issue (bug ) #12618#14553
shashank1225 wants to merge1 commit intobokeh:branch-3.9fromshashank1225:fix-colorbar-formatter-test
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJul 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## branch-3.8 #14553 +/- ##============================================= Coverage ? 93.24% ============================================= Files ? 284 Lines ? 20240 Branches ? 0 ============================================= Hits ? 18872 Misses ? 1368 Partials ? 0 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where ColorBar tick labels showed overly precise decimal values (like 0.7000000000000001) when no formatter was provided. To improve the default output, we added a NumeralTickFormatter(format="0.00") as the default formatter using the Override method in the ColorBar class. This ensures cleaner and more readable tick labels. As a result of this fix, the test test_ColorBar in test_annotations.py was failing since it expected the formatter to be "auto". The test was updated to assert that the default formatter is a NumeralTickFormatter and its format is "0.00".