Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Jaivon Massena#303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jaivonmassena wants to merge4 commits intobloominstituteoftechnology:master
base:master
Choose a base branch
Loading
fromjaivonmassena:master

Conversation

@jaivonmassena
Copy link

No description provided.

@justinborek
Copy link

What Went Well:

Nice work, and welcome to JS! You were able to complete most of the tasks, and your code looked pretty good for most of the assignment. Your solutions were concise, and your choice of variable names is readable. Good job!

Areas For Improvement:

FormapObject, a possible solution could have been ```Object.keys(obj).forEach(key => (obj[key] = cb(obj[key])));

return obj;``` , where you're using the keys of the object as the index to pass the values to the callback function. Also, in yourarrays.js `filter` method, make sure your `newel` var is camelCased to `newEl`. Lastly, keep shooting for those stretch goals!

Questions:

None! Good work!

Rating (1-3):

2

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaivonmassena@justinborek

[8]ページ先頭

©2009-2025 Movatter.jp