Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add cif-seqres-author and cif-atom-label seq parsers#4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
StefansM wants to merge1 commit intobiopython:master
base:master
Choose a base branch
Loading
fromStefansM:bugfix/cif-seqres-author-label-chain-ids

Conversation

@StefansM
Copy link
Contributor

Draft pull request to illustrate#4922.

  • TheCifSeqresIterator (cif-seqres) uses "label" IDs (_pdbx_poly_seq_scheme.asym_id), which are assigned by the PDB, always start at "A" and move through the alphabet one letter at a time.

  • TheCifAtomIterator (cif-atom) uses "author" IDs, which are arbitrarily assigned by the structure authors (this is what you get in traditional fixed-width PDB files).

I agree that this mismatch is probably a bug, though it would be a backwards incompatible change to fix it. If you don't care about the author IDs, and you just need the chain IDs of the sequence fromcif-seqres to match the chain IDs of the atoms parsed byMMCIFParser, you could passauth_chains=False toMMCIFParser to use label IDs in the structure as well.

To fix this, theCifSeqresIterator could be modified to use author IDs by reading
_pdbx_poly_seq_scheme.pdb_strand_id. Or theCifAtomIterator could passauth_chains=False toMMCIFParser to use label IDs everywhere.

  • I hereby agree to dual licence this and any previous contributions under both
    theBiopython License AgreementAND theBSD 3-Clause License.

  • I have read theCONTRIBUTING.rst file, have runpre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst andCONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

Closes #...

Seebiopython#4922.* The `CifSeqresIterator` (`cif-seqres`) uses "label" IDs  ([`_pdbx_poly_seq_scheme.asym_id`][_pdbx_poly_seq_scheme.asym_id]),  which are assigned by the PDB, always start at "A" and move through the  alphabet one letter at a time.* The `CifAtomIterator` (`cif-atom`) uses "author" IDs, which are  arbitrarily assigned by the structure authors (this is what you get in  traditional fixed-width PDB files).I agree that this mismatch is probably a bug, though it would be abackwards incompatible change to fix it. If you don't care about theauthor IDs, and you just need the chain IDs of the sequence from`cif-seqres` to match the chain IDs of the atoms parsed by`MMCIFParser`, you could pass `auth_chains=False` to `MMCIFParser` touse label IDs in the structure as well.To fix this, the `CifSeqresIterator` could be modified to use author IDsby reading[`_pdbx_poly_seq_scheme.pdb_strand_id`][_pdbx_poly_seq_scheme.pdb_strand_id].Or the `CifAtomIterator` could pass `auth_chains=False` to `MMCIFParser`to use label IDs everywhere.[_pdbx_poly_seq_scheme.asym_id]:https://mmcif.wwpdb.org/dictionaries/mmcif_pdbx_v50.dic/Items/_pdbx_poly_seq_scheme.asym_id.html[_pdbx_poly_seq_scheme.pdb_strand_id]:https://mmcif.wwpdb.org/dictionaries/mmcif_ma.dic/Items/_pdbx_poly_seq_scheme.pdb_strand_id.html
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@peterjcpeterjcAwaiting requested review from peterjcpeterjc will be requested when the pull request is marked ready for reviewpeterjc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@StefansM

[8]ページ先頭

©2009-2025 Movatter.jp