Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Gradient Boosting - Remove try/catch around imports#6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
PrimozGodec wants to merge4 commits intobiolab:master
base:master
Choose a base branch
Loading
fromPrimozGodec:boosting-remove-imports

Conversation

@PrimozGodec
Copy link
Contributor

@PrimozGodecPrimozGodec commentedSep 21, 2023•
edited
Loading

Issue

After#6570, try/catch around xgboost/catboost methods is not required anymore since packages are always installed

Description of changes

Remove try/catch around imports, skips in tests, and simplify parts of the code.

This PR also fix translations since the check is currently failing on the master.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodecPrimozGodecforce-pushed theboosting-remove-imports branch 2 times, most recently from130bbcf to297ec2cCompareSeptember 21, 2023 13:32
@markotoplak
Copy link
Member

Come on, let's wait a bit with this so that we see if the added requirements create problems for anyone. I am making this a draft.

@markotoplakmarkotoplak marked this pull request as draftSeptember 21, 2023 17:05
@PrimozGodecPrimozGodec marked this pull request as ready for reviewJanuary 11, 2024 16:31
@PrimozGodec
Copy link
ContributorAuthor

/rebase

@codecov
Copy link

codecovbot commentedJan 11, 2024•
edited
Loading

Codecov Report

Merging#6584 (637f695) intomaster (7233533) willdecrease coverage by0.02%.
The diff coverage is100.00%.

❗ Current head637f695 differs from pull request most recent head360b7b3. Consider uploading reports for the commit360b7b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##           master    #6584      +/-   ##==========================================- Coverage   88.07%   88.05%   -0.02%==========================================  Files         322      322                Lines       70254    70226      -28     ==========================================- Hits        61874    61841      -33- Misses       8380     8385       +5

@PrimozGodecPrimozGodec marked this pull request as draftJanuary 11, 2024 17:04
@PrimozGodecPrimozGodec marked this pull request as ready for reviewJanuary 12, 2024 07:50
@PrimozGodec
Copy link
ContributorAuthor

I think it can be reviewed and merged now.

@markotoplak
Copy link
Member

I'd wait with this a little bit now that newest xgboost version started not packing libomp again. Perhaps we should even think about dropping the requirement...

@markotoplakmarkotoplak marked this pull request as draftJuly 26, 2024 13:02
@markotoplakmarkotoplak removed their assignmentJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PrimozGodec@markotoplak
[8]ページ先頭
©2009-2025 Movatter.jp