Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Inform the client if it subscribes to a new topic#979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
karmanyaahm wants to merge6 commits intobinwiederhier:main
base:main
Choose a base branch
Loading
fromkarmanyaahm:main

Conversation

@karmanyaahm
Copy link
Contributor

@karmanyaahmkarmanyaahm commentedDec 16, 2023
edited
Loading

  • Reject Matrix with 200 and rejected pushkey instead of returning 5xx
  • Set UnifiedPush 'can't publish' error to 404
  • Implement a NeverSubscribed() method in topics to keep track of new topics
  • add the "new_topic" param to the open message
  • Return new_topic in the open message when any of the list of topics subscribed to is new. Not the most information, but the likelihood of topics from the same client have different statuses is so tiny and rare, that clients can resubscribe all to be safe.

Deployment
I think the Android app needs to be released first, before the server is deployed, so the client can deal with the case of re-registration on 404.

Paired withbinwiederhier/ntfy-android#70
Closes#664

ShadowJonathan, p1gp1g, and CrazyWolf13 reacted with heart emojiShadowJonathan reacted with eyes emoji
@codecov-commenter
Copy link

codecov-commenter commentedDec 17, 2023
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is82.60870% with4 lines in your changes missing coverage. Please review.

Project coverage is 65.85%. Comparing base(bb4b5d2) to head(ec79778).
Report is 172 commits behind head on main.

FilesPatch %Lines
server/server.go55.55%3 Missing and 1 partial⚠️

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##             main     #979      +/-   ##==========================================+ Coverage   65.82%   65.85%   +0.02%==========================================  Files          53       53                Lines        7737     7746       +9     ==========================================+ Hits         5093     5101       +8- Misses       1799     1801       +2+ Partials      845      844       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@karmanyaahmkarmanyaahm marked this pull request as ready for reviewDecember 17, 2023 23:20
@CrazyWolf13
Copy link

@binwiederhier
Hi
Could you have a look at this PR yet, I would love to see this functionality, and seems like there is already a good PR made, which has now sadly been open and unreviewed for over a year.

Thanks for looking into this, once you find some time :)

Would really appreciate!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UnifiedPush: Respond with 404/409/... to Mastodon/etc. instead of 507 based on User-Agent

3 participants

@karmanyaahm@codecov-commenter@CrazyWolf13

[8]ページ先頭

©2009-2025 Movatter.jp