Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
WIP: Update notifications#1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
wunter8 wants to merge3 commits intobinwiederhier:mainChoose a base branch fromwunter8:303-update-notifications
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
wcypierre commentedDec 6, 2025
Any updates on this? |
ContributorAuthor
wunter8 commentedDec 6, 2025
Not yet, no |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows notification content to be updated in the web app by sending multiple messages with the same
sequence id(sid).Here is a small video demo:
message-update-demo.mp4
I tried to make sure that things still work if this new version of the web app subscribes to a topic on an "old" ntfy server (a server that doesn't provide
mtimeorsidfields).The server doesn't support "deleting" notifications (dismissing from the notification shade) yet, just updating.
The web app cannot "delete" notifications programmatically since "silent" pushes are not allowed. (i.e., sending a JSON object with a message ID to delete and not showing any notification as a result of that JSON object is not allowed. Deleting should work fine on Android, though.)
@binwiederhier you'll need to decide how we present all this visually in the web app. I just wanted to get the information on there somewhere.
All the revisions of a particular message are attached to the one visible notification, so we could create some sort of dialog/modal to show the past revisions of a message. But I figured we could do that later, once everything else is working.