- Notifications
You must be signed in to change notification settings - Fork537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Add support for custom types in function parameters#504
Open
Cheyenne1025 wants to merge5 commits intobetalgo:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat: Add support for custom types in function parameters#504
Cheyenne1025 wants to merge5 commits intobetalgo:devfromCheyenne1025:add-function-definition-support-handle-custom-type
+225 −17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Update `GetFunctionDefinition` method to handle custom types as function parameters - Recursively process properties of custom types - Generate object type property definitions for custom types- Add `GetPropertyDefinition` method to create property definitions based on property type- Update `CallFunction` method to handle custom type parameters- Add tests for custom type support - `VerifyGetFunctionDefinition_CustomType` test to verify function definition generation for custom types - `VerifyCallFunction_CustomType` test to verify function calling with custom type parameters- Add tests for complex custom types - `VerifyGetFunctionDefinition_ComplexCustomType` test to verify function definition generation for complex custom types with nested custom types - `VerifyCallFunction_ComplexCustomType` test to verify function calling with complex custom type parameters- Add `CustomType` and `ComplexCustomType` classes for testing purposes
Removable commentedMar 22, 2024
It seems we have to set the |
The unit test you wrote is failing. Could you please fix it? |
The code is unable to handle self-referenced objects. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFunctionDefinitionmethod to handle custom types as function parametersGetPropertyDefinitionmethod to create property definitions based on property typeCallFunctionmethod to handle custom type parametersVerifyGetFunctionDefinition_CustomTypetest to verify function definition generation for custom typesVerifyCallFunction_CustomTypetest to verify function calling with custom type parametersVerifyGetFunctionDefinition_ComplexCustomTypetest to verify function definition generation for complex custom types with nested custom typesVerifyCallFunction_ComplexCustomTypetest to verify function calling with complex custom type parametersCustomTypeandComplexCustomTypeclasses for testing purposes