Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Feature/catch multiline benchmarks#46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bernedom wants to merge2 commits intobenchmark-action:master
base:master
Choose a base branch
Loading
frombernedom:feature/catch-multiline-benchmarks

Conversation

@bernedom
Copy link
Contributor

If Benchmark names are too long, catch wraps them which caused the github action to fail.
Adapted the regex to accommodate for this case.

bitbacchus and amloginov reacted with heart emoji
spl pushed a commit to terminusdb-labs/benchmark-tracker that referenced this pull requestAug 5, 2021
@ghost
Copy link

I encountered the same issue, would be great to get this merged and released.

As a workaround we can add#define CATCH_CONFIG_CONSOLE_WIDTH 200 (or any width needed) in the benchmark source to overwrite catch2's default output width of 80 characters to prevent long benchmark names wrapping.

bernedom reacted with thumbs up emoji

@bernedom
Copy link
ContributorAuthor

As a workaround we can add#define CATCH_CONFIG_CONSOLE_WIDTH 200 (or any width needed) in the benchmark source to overwrite catch2's default output width of 80 characters to prevent long benchmark names wrapping.

That's actually a quite decend workaround until this is merged. Did not know that catch allows to configure this.

@wwerkk
Copy link

wwerkk commentedMar 22, 2024•
edited
Loading

Any updates on this PR?
Unless I am missing something, overwriting the width doesn't seem to be an option if Catch2 is fetched with CMake

@wwerkk
Copy link

Any updates on this PR? Unless I am missing something, overwriting the width doesn't seem to be an option if Catch2 is fetched with CMake

solved the problem by addingset(CATCH_CONFIG_CONSOLE_WIDTH 200) before fetching Catch2 in CMakeLists.txt

bernedom reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernedom@wwerkk
[8]ページ先頭
©2009-2025 Movatter.jp