Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use human readable durations#296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
414owen wants to merge1 commit intobenchmark-action:master
base:master
Choose a base branch
Loading
from414owen:os/pretty-durations

Conversation

@414owen
Copy link
Contributor

@414owen414owen commentedFeb 11, 2025•
edited
Loading

Benchmark reports that show, eg. 472666693ns/iter, are very difficult to scan.

This change formats benchmarks measured inns/iter with a more human readable duration.

Example output:414owen/outlines-core#7

@ktrz

@414owen414owen marked this pull request as draftFebruary 11, 2025 16:19
@414owen414owenforce-pushed theos/pretty-durations branch 3 times, most recently fromc049ca9 to8d0f52aCompareFebruary 11, 2025 18:18
@ktrz
Copy link
Member

Thank you for your contribution@414owen!

Could you please have a look at the failing tests and lint checks and fix those issues?

@414owen414owenforce-pushed theos/pretty-durations branch 4 times, most recently from9592783 tobfec205CompareMay 16, 2025 21:59
@414owen
Copy link
ContributorAuthor

@ktrz this should be ready for another pair of eyes

@414owen414owen marked this pull request as ready for reviewAugust 20, 2025 16:41
@ktrz
Copy link
Member

ktrz commentedSep 2, 2025

Hey@414owen

Thank you for fixing the lint issues and adding tests!

I've noticed that this only works forns/iter. It would be great to handle other units as well, likeus,ms, etc. Both in different formats as well like<time unit>,<time unit>/iter, andops/<time unit>.

Would you mind adding handling for those cases as well and also add some test cases specifically for the things you are trying to improve?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@414owen@ktrz
[8]ページ先頭
©2009-2025 Movatter.jp