- Notifications
You must be signed in to change notification settings - Fork176
Track historic best results and (optionally) compute ratio based on best results#124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ksvladimir wants to merge2 commits intobenchmark-action:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If it reaches a super good value by transient issue for one time, will be "Best" be corrupted and it will consistently alert until you fix the data point manually? Alternatively, what do you think of setting an absolute threshold for your use case? Or thinking about a better stats value instead of "Best", like "Median during recent period"? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for providing this awesome action that our team greatly enjoys!
Our team got concerned that, since this action shows alerts based on comparison to the previous run only, it wouldn't catch gradual performance degradation over several commits. Such degradation is very real, especially when using this action for end-to-end benchmarks: the code becomes a bit slower (but below the alert threshold) with each new feature added, and eventually, it reaches the point where we want to revisit its performance — ideally as advised by an alert from this action.
This PR makes this action usable for detecting performance degradation over time in end-to-end benchmarks by:
Bestvalue for each benchmark in commit comments (in addition to previous and current values)bestbenchmark instead of the previous one for computing ratios and triggering alertsWe'd appreciate your consideration for including this PR in this action!