Commite02d8b6

Alex Belozierov

committed

- improved await() performance

1 parentbb23886 commite02d8b6Copy full SHA for e02d8b6

File tree

+38

-3

lines changed

Sources/SwiftCoroutine/Coroutine/SharedCoroutineDispatcher
- SharedCoroutine.swift
SwiftCoroutine.xcodeproj/xcshareddata/xcbaselines/F8CD25A920199D1000952299.xcbaseline
- DEB0EA3A-457C-4029-95F2-69E53CE6D25D.plist
Tests/SwiftCoroutineTests/CoFutureTests
- CoFutureAwaitTests.swift

+38

-3

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ internal final class SharedCoroutine {`
`22`	`22`	`privatevarenvironment:UnsafeMutablePointer<CoroutineContext.SuspendData>!`
`23`	`23`	`privatevarstackBuffer:StackBuffer!`
`24`	`24`	`privatevarisCanceled=0`
	`25`	`+privatevarawaitTag=0`
`25`	`26`
`26`	`27`	`internalinit(dispatcher:SharedCoroutineDispatcher, queue:SharedCoroutineQueue, scheduler:CoroutineScheduler){`
`27`	`28`	`self.dispatcher= dispatcher`
`@@ -96,9 +97,13 @@ extension SharedCoroutine: CoroutineProtocol {`
`96`	`97`	`internalfunc await<T>(_ callback:(@escaping(T)->Void)->Void)throws->T{`
`97`	`98`	`if isCanceled==1{throwCoroutineError.canceled}`
`98`	`99`	`state=.suspending`
`99`		`-varresult:T!,resultState=0`
	`100`	`+lettag= awaitTag`
	`101`	`+varresult:T!`
`100`	`102`	`callback{ valuein`
`101`		`-ifatomicExchange(&resultState, with:1)==1{return}`
	`103`	`+whiletrue{`
	`104`	`+guardself.awaitTag== tagelse{return}`
	`105`	`+ifatomicCAS(&self.awaitTag, expected: tag, desired: tag+1){break}`
	`106`	`+}`
`102`	`107`	`result= value`
`103`	`108`	`self.resumeIfSuspended()`
`104`	`109`	`}`

Lines changed: 21 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,26 @@`
`19`	`19`	`</dict>`
`20`	`20`	`<key>CoFutureAwaitTests</key>`
`21`	`21`	`<dict>`
	`22`	`+<key>testAbc()</key>`
	`23`	`+<dict>`
	`24`	`+<key>com.apple.XCTPerformanceMetric_WallClockTime</key>`
	`25`	`+<dict>`
	`26`	`+<key>baselineAverage</key>`
	`27`	`+<real>0.50477</real>`
	`28`	`+<key>baselineIntegrationDisplayName</key>`
	`29`	`+<string>Local Baseline</string>`
	`30`	`+</dict>`
	`31`	`+</dict>`
	`32`	`+<key>testAwaitMeasure()</key>`
	`33`	`+<dict>`
	`34`	`+<key>com.apple.XCTPerformanceMetric_WallClockTime</key>`
	`35`	`+<dict>`
	`36`	`+<key>baselineAverage</key>`
	`37`	`+<real>0.056</real>`
	`38`	`+<key>baselineIntegrationDisplayName</key>`
	`39`	`+<string>Local Baseline</string>`
	`40`	`+</dict>`
	`41`	`+</dict>`
`22`	`42`	`<key>testMultipleAwaits()</key>`
`23`	`43`	`<dict>`
`24`	`44`	`<key>com.apple.XCTPerformanceMetric_WallClockTime</key>`
`@@ -44,7 +64,7 @@`
`44`	`64`	`<key>com.apple.XCTPerformanceMetric_WallClockTime</key>`
`45`	`65`	`<dict>`
`46`	`66`	`<key>baselineAverage</key>`
`47`		`-<real>0.121</real>`
	`67`	`+<real>0.0836</real>`
`48`	`68`	`<key>baselineIntegrationDisplayName</key>`
`49`	`69`	`<string>Local Baseline</string>`
`50`	`70`	`</dict>`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,16 @@ class CoFutureAwaitTests: XCTestCase {`
`45`	`45`	`XCTAssertTrue(array.enumerated().allSatisfy{ $0.element== $0.offset})`
`46`	`46`	`array.deallocate()`
`47`	`47`	`}`
	`48`	`+`
	`49`	`+func testAwaitMeasure(){`
	`50`	`+measure{`
	`51`	`+ImmediateScheduler().startCoroutine{`
	`52`	`+forindexin0..<100_000{`
	`53`	`+let _=tryCoroutine.await{$0(index)}`
	`54`	`+}`
	`55`	`+}`
	`56`	`+}`
	`57`	`+}`
`48`	`58`
`49`	`59`	`func testNestetAwaits(){`
`50`	`60`	`letqueue=DispatchQueue.global(qos:.userInteractive)`

Comments

(0)