Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitcce118a

Browse files
committed
Code cleanup.
1 parent4ef1404 commitcce118a

File tree

5 files changed

+18
-34
lines changed

5 files changed

+18
-34
lines changed

‎Bin/Win32/settings.json‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"DebugMode":false,
3-
"EmitLogMessages":true,
3+
"EmitLogMessages":false,
44
"FormSettings": {
5-
"Left":-8,
5+
"Left":2552,
66
"Top":-8,
77
"Width":2576,
88
"Height":1426,
@@ -14,30 +14,30 @@
1414
"AutoFilterMessages":true,
1515
"ColumnHeadersVisible":true,
1616
"DynamicAutoSizeColumns":true,
17-
"MessageDetailsVisible":false,
17+
"MessageDetailsVisible":true,
1818
"SmartTimeStamps":true,
1919
"HorizontalPanelPositions": [
20-
0.25678496868476,
21-
0.704225352112676,
20+
0.270909090909091,
21+
0.666666666666667,
2222
1
2323
],
2424
"LeftVerticalPanelPositions": [
25-
0.0978147762747138,
25+
0.205234159779614,
2626
1
2727
]
2828
},
2929
"WinodsSettings": {
3030
"Enabled":false
3131
},
3232
"WinipcSettings": {
33-
"Enabled":false,
33+
"Enabled":true,
3434
"PollingInterval":100
3535
},
3636
"ZeroMQSettings": {
37-
"Enabled":true,
37+
"Enabled":false,
3838
"PollingInterval":100,
3939
"PollingTimeout":10,
40-
"Endpoints":"default localhost=tcp://localhost:5555\r\nLogViewer=tcp://localhost:42134\r\nBaltaPC=tcp://SBVCTITPO47:5555\r\n"
40+
"Endpoints":"default localhost=tcp://localhost:5555\r\nLogViewer=tcp://localhost:42134\r\nBaltaPC=tcp://SBVCTITPO47:5555\r\nBaltaPC_1=tcp://SBVCTITPOA8:5555\r\n"
4141
},
4242
"FileSystemSettings": {
4343
"Enabled":false,
@@ -188,7 +188,7 @@
188188
"WatchSettings": {
189189
"ColumnHeadersVisible":false,
190190
"OnlyTrackChanges":true,
191-
"WatchHistoryVisible":false,
191+
"WatchHistoryVisible":true,
192192
"SyncWithSelection":false
193193
},
194194
"CallStackSettings": {

‎LogViewer.MainForm.pas‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,9 @@ destructor TfrmMain.Destroy;
260260
FSettings.FormSettings.Assign(Self);
261261
FManager :=nil;
262262
FreeAndNil(FDashboard);// needs to be freed before manager!
263-
264-
try
265-
inherited Destroy;// will destroy manager object as the mainform is its owner
266-
finally
267-
FSettings.OnChanged.RemoveAll(Self);
268-
FreeAndNil(FSettings);
269-
end;
263+
inherited Destroy;// will destroy manager object as the mainform is its owner
264+
FSettings.OnChanged.RemoveAll(Self);
265+
FreeAndNil(FSettings);
270266
end;
271267
{$ENDREGION}
272268

‎LogViewer.Manager.pas‎

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -311,10 +311,8 @@ procedure TdmManager.AfterConstruction;
311311
FCommands := TLogViewerCommands.Create(Self);
312312
FReceivers := TCollections.CreateInterfaceList<IChannelReceiver>;
313313
FViewList := TCollections.CreateInterfaceList<ILogViewer>;
314-
// FEditorSettings := TEditorFactories.CreateSettings(Self, 'settings.xml');
315-
// FEditorManager := TEditorFactories.CreateManager(Self, FEditorSettings);
316-
//FEditorSettings := TEditorFactories.CreateSettings(Application, 'settings.xml');
317-
FEditorManager := TEditorFactories.CreateManager(nil,nil);
314+
FEditorSettings := TEditorFactories.CreateSettings(Self,'settings.xml');
315+
FEditorManager := TEditorFactories.CreateManager(Self, FEditorSettings);
318316
InitializeEditorActions;
319317
BuildMessageTypesPopupMenu;
320318
BuildLogTreeViewerPopupMenu;
@@ -328,8 +326,6 @@ procedure TdmManager.AfterConstruction;
328326
end;
329327

330328
destructor TdmManager.Destroy;
331-
//var
332-
// C : TComponent;
333329
begin
334330
Logger.Track(Self,'Destroy');
335331
FActiveView :=nil;
@@ -343,23 +339,15 @@ destructor TdmManager.Destroy;
343339
FViewList :=nil;
344340
FReceivers :=nil;
345341
FSettings :=nil;
346-
// C := FEditorManager.AsComponent;
347342
FEditorSettings :=nil;
348343
FEditorManager :=nil;
349344

350-
351-
352345
FreeAndNil(FEvents);// needs to happen just before inherited call
353346
FreeAndNil(FCommands);
354-
355-
//Logger.SendComponent('Manager', Self);
356-
//Logger.SendObject('Manager', Self);
357-
358347
inherited Destroy;// results in exception when application is closed with
359348
// - one message viewer
360349
// - that has not been focused
361-
362-
//FreeAndNil(C);
350+
//TODO => This issue is caused by the EditorManager instance
363351
end;
364352
{$ENDREGION}
365353

‎LogViewer.dproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
</PropertyGroup>
9999
<PropertyGroup Condition="'$(Cfg_2_Win32)'!=''">
100100
<AppEnableRuntimeThemes>true</AppEnableRuntimeThemes>
101-
<VerInfo_Keys>CompanyName=Tim Sinaeve;FileDescription=LogViewer;FileVersion=1.9.6.366;ProductName=LogViewer;ProductVersion=1.9.6;LegalCopyright=2013 - 2021 (c) Tim Sinaeve;OriginalFilename=LogViewer.exe</VerInfo_Keys>
101+
<VerInfo_Keys>CompanyName=Tim Sinaeve;FileDescription=LogViewer;FileVersion=1.9.6.367;ProductName=LogViewer;ProductVersion=1.9.6;LegalCopyright=2013 - 2021 (c) Tim Sinaeve;OriginalFilename=LogViewer.exe</VerInfo_Keys>
102102
<DCC_IntegerOverflowCheck>true</DCC_IntegerOverflowCheck>
103103
<DCC_RangeChecking>true</DCC_RangeChecking>
104104
<DCC_DebugInfoInExe>true</DCC_DebugInfoInExe>
@@ -109,7 +109,7 @@
109109
<DCC_RunTimeTypeInfo>true</DCC_RunTimeTypeInfo>
110110
<DCC_DebugInfoInTds>true</DCC_DebugInfoInTds>
111111
<AppDPIAwarenessMode>PerMonitor</AppDPIAwarenessMode>
112-
<VerInfo_Build>366</VerInfo_Build>
112+
<VerInfo_Build>367</VerInfo_Build>
113113
</PropertyGroup>
114114
<ItemGroup>
115115
<DelphiCompile Include="$(MainSource)">

‎LogViewer.res‎

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp