- Notifications
You must be signed in to change notification settings - Fork155
Use newer split module flag with Swift 5.4#699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyft-lint-bot commentedOct 14, 2021
Lyft integration job started:https://buildkite.com/lyft/rules-swift/builds/71 (must be Lyft employee to view) |
I'm not sure how to make the test differ based on Xcode version used. |
do the embedded swiftdeps include all the normal things like timestamps? |
🙏🏻 |
Uses the newer `-experimental-skip-non-inlinable-function-bodies-without-types` which was introduced here:swiftlang/swift#34612. This should improve LLDB usage in some cases.When using WMO, it has two downsides in Swift 5.5, both introduced byswiftlang/swift#38939:- The swiftmodules will have swiftdeps info embedded in them, which is only needed for incremental compilation- Interface hashing is enabled, which again is only needed for incremental compilationThis is because the swift compiler only expects `-experimental-skip-non-inlinable-function-bodies-without-types` to be used with the new `emit-module-separately` incremental build.
fc0aca0 to53ba099CompareSeems like the issues I raised are still there. will need to test if it's an issue having those extra things before deciding to take this. |
If it does have issues, it seems we should only use this flavor for incremental builds. |
Uh oh!
There was an error while loading.Please reload this page.
Uses the newer
-experimental-skip-non-inlinable-function-bodies-without-typeswhich was introduced here:swiftlang/swift#34612. This should improve LLDB usage in some cases.When using WMO, it has two downsides in Swift 5.5, both introduced byswiftlang/swift#38939:
This is because the swift compiler only expects
-experimental-skip-non-inlinable-function-bodies-without-typesto be used with the new-emit-module-separatelyincremental build. In the same vein, in order to support split modules with incremental builds, we need to use this flag (though we could choose to use this versiononly with incremental + split modules, if we decide it's not worth the above regressions).