Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: rules_swift 4.x base#1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
luispadron wants to merge13 commits intomaster
base:master
Choose a base branch
Loading
fromluis/4.x
Draft

WIP: rules_swift 4.x base#1571

luispadron wants to merge13 commits intomasterfromluis/4.x

Conversation

@luispadron
Copy link
Contributor

@luispadronluispadron commentedSep 23, 2025
edited
Loading

  • Remove incremental compilation support
  • Remove persistent worker code
  • Add dependency onabseil (bzlmod and WORKSPACE)
  • Add dependency onre2 (bzlmod and WORKSPACE)
  • Syncswift_runner code (and related util) from upstream
  • Add initial commit supporting parallel compilation

@qyang-nj
Copy link
Contributor

Just curious: what's the motivation to remove incremental compilation?

@brentleyjones
Copy link
Collaborator

It's removed in Google's upstream branch. More context / us asking for feedback:https://bazelbuild.slack.com/archives/CD3QY5C2X/p1758578665272229.

qyang-nj reacted with thumbs up emoji

…is being used.Unless cross-module-optimization is disabled (which we don't really support at this time), the driver in this case will create a single frontend invocation that emits both the module and performs codegen.Cherry-pick of upstream:29f0ec2
…ty string instead of the full list of object files.This reduces unnecessary processing for huge modules with hundreds of source files.Cherry-pick:c413bd3
@luispadronluispadronforce-pushed theluis/4.x branch 2 times, most recently from9eee21a to87abef8CompareSeptember 26, 2025 03:44
luispadronand others added5 commitsSeptember 25, 2025 23:54
…mization modes interact as we expect.The tests highlight a couple cases that are currently known to be wrong so we can fix and test them without just manually building all possible combinations.Chery-pick:f6302a2
Explicitly disable cross-module optimization in `exec` configs so that Swift tools can be built in parallel to speed up critical build paths.Cherry-pic:d1ecc8a
Signed-off-by: Brentley Jones <github@brentleyjones.com>
…llel compilation.In the future, we should consider whether we should more strictly control where these flags can be applied, since they don't just control optimizations but also how the driver plans its work.Cherry-pick:ab55a12
…sed and `-wmo` is passed on the command line.Cherry-pick:66a6a6b
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aaronskyaaronskyAwaiting requested review from aaronskyaaronsky will be requested when the pull request is marked ready for reviewaaronsky is a code owner

@adincebicadincebicAwaiting requested review from adincebicadincebic will be requested when the pull request is marked ready for reviewadincebic is a code owner

@brentleyjonesbrentleyjonesAwaiting requested review from brentleyjonesbrentleyjones will be requested when the pull request is marked ready for reviewbrentleyjones is a code owner

@keithkeithAwaiting requested review from keithkeith will be requested when the pull request is marked ready for reviewkeith is a code owner

@mattrobmattrobmattrobmattrobAwaiting requested review from mattrobmattrobmattrobmattrob will be requested when the pull request is marked ready for reviewmattrobmattrob is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luispadron@qyang-nj@brentleyjones

[8]ページ先頭

©2009-2025 Movatter.jp