- Notifications
You must be signed in to change notification settings - Fork155
WIP: rules_swift 4.x base#1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
luispadron wants to merge13 commits intomasterChoose a base branch fromluis/4.x
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Just curious: what's the motivation to remove incremental compilation? |
It's removed in Google's upstream branch. More context / us asking for feedback:https://bazelbuild.slack.com/archives/CD3QY5C2X/p1758578665272229. |
…is being used.Unless cross-module-optimization is disabled (which we don't really support at this time), the driver in this case will create a single frontend invocation that emits both the module and performs codegen.Cherry-pick of upstream:29f0ec2
…ty string instead of the full list of object files.This reduces unnecessary processing for huge modules with hundreds of source files.Cherry-pick:c413bd3
…p specific mnemonics.
9eee21a to87abef8Compare…mization modes interact as we expect.The tests highlight a couple cases that are currently known to be wrong so we can fix and test them without just manually building all possible combinations.Chery-pick:f6302a2
Explicitly disable cross-module optimization in `exec` configs so that Swift tools can be built in parallel to speed up critical build paths.Cherry-pic:d1ecc8a
Signed-off-by: Brentley Jones <github@brentleyjones.com>
…llel compilation.In the future, we should consider whether we should more strictly control where these flags can be applied, since they don't just control optimizations but also how the driver plans its work.Cherry-pick:ab55a12
…sed and `-wmo` is passed on the command line.Cherry-pick:66a6a6b
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
abseil(bzlmod and WORKSPACE)re2(bzlmod and WORKSPACE)swift_runnercode (and related util) from upstream