Commitf6b6b42

committed

Initialize timeout remote address when channel was pooled,closeAsyncHttpClient#1363

Motivation:When channel was fetched from pool, we fail to initialize the remoteaddress, causing timeout exceptions to say «not-connected ».Modification:Properly initializeResult:No more erroneous « not-connected ».

1 parent9ed24f2 commitf6b6b42Copy full SHA for f6b6b42

File tree

1 file changed

-2

lines changed

client/src/main/java/org/asynchttpclient/netty/request
- NettyRequestSender.java

1 file changed

-2

lines changed

`‎client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,8 @@ private <T> ListenableFuture<T> sendRequestWithOpenChannel(Request request, Prox`
`214`	`214`	`if (asyncHandlerinstanceofAsyncHandlerExtensions)`
`215`	`215`	`AsyncHandlerExtensions.class.cast(asyncHandler).onConnectionPooled(channel);`
`216`	`216`
`217`		`-scheduleRequestTimeout(future);`
	`217`	`+TimeoutsHoldertimeoutsHolder =scheduleRequestTimeout(future);`
	`218`	`+timeoutsHolder.initRemoteAddress((InetSocketAddress)channel.remoteAddress());`
`218`	`219`	`future.setChannelState(ChannelState.POOLED);`
`219`	`220`	`future.attachChannel(channel,false);`
`220`	`221`
`@@ -376,10 +377,11 @@ private void configureTransferAdapter(AsyncHandler<?> handler, HttpRequest httpR`
`376`	`377`	`TransferCompletionHandler.class.cast(handler).headers(h);`
`377`	`378`	`}`
`378`	`379`
`379`		`-privatevoidscheduleRequestTimeout(NettyResponseFuture<?>nettyResponseFuture) {`
	`380`	`+privateTimeoutsHolderscheduleRequestTimeout(NettyResponseFuture<?>nettyResponseFuture) {`
`380`	`381`	`nettyResponseFuture.touch();`
`381`	`382`	`TimeoutsHoldertimeoutsHolder =newTimeoutsHolder(nettyTimer,nettyResponseFuture,this,config);`
`382`	`383`	`nettyResponseFuture.setTimeoutsHolder(timeoutsHolder);`
	`384`	`+returntimeoutsHolder;`
`383`	`385`	`}`
`384`	`386`
`385`	`387`	`privatevoidscheduleReadTimeout(NettyResponseFuture<?>nettyResponseFuture) {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf6b6b42

File tree

1 file changed

1 file changed

`‎client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java‎`

0 commit comments