Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitcec67cf

Browse files
plokhotnyukslandelle
authored andcommitted
Reduce GC overhead by call address.toString() in case of timeout only (AsyncHttpClient#1401)
1 parent6aaed08 commitcec67cf

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

‎client/src/main/java/org/asynchttpclient/netty/timeout/TimeoutsHolder.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class TimeoutsHolder {
3838
privatevolatileNettyResponseFuture<?>nettyResponseFuture;
3939
publicfinalTimeoutrequestTimeout;
4040
publicvolatileTimeoutreadTimeout;
41-
privatevolatileStringremoteAddress ="not-connected";
41+
privatevolatileInetSocketAddressremoteAddress;
4242

4343
publicTimeoutsHolder(TimernettyTimer,NettyResponseFuture<?>nettyResponseFuture,NettyRequestSenderrequestSender,AsyncHttpClientConfigconfig) {
4444
this.nettyTimer =nettyTimer;
@@ -61,7 +61,7 @@ public TimeoutsHolder(Timer nettyTimer, NettyResponseFuture<?> nettyResponseFutu
6161
}
6262

6363
publicvoidinitRemoteAddress(InetSocketAddressaddress) {
64-
remoteAddress =address.toString();
64+
remoteAddress =address;
6565
}
6666

6767
publicvoidstartReadTimeout() {
@@ -77,8 +77,7 @@ void startReadTimeout(ReadTimeoutTimerTask task) {
7777
// first call triggered from outside (else is read timeout is re-scheduling itself)
7878
task =newReadTimeoutTimerTask(nettyResponseFuture,requestSender,this,readTimeoutValue);
7979
}
80-
TimeoutreadTimeout =newTimeout(task,readTimeoutValue);
81-
this.readTimeout =readTimeout;
80+
this.readTimeout =newTimeout(task,readTimeoutValue);
8281

8382
}elseif (task !=null) {
8483
// read timeout couldn't re-scheduling itself, clean up
@@ -104,6 +103,6 @@ private Timeout newTimeout(TimerTask task, long delay) {
104103
}
105104

106105
StringremoteAddress() {
107-
returnremoteAddress;
106+
returnremoteAddress ==null ?"not-connected" :remoteAddress.toString();
108107
}
109108
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp