Commita3e6421

gculik

authored and

slandelle

committed

Fixed integer overflow when file size > Integer.MAX_INT,closeAsyncHttpClient#1342

Motivation:`FilePart` currently uses an int to track written length. Huge files can cause an overflow.Modification:Use a long instead of an intResult:No more overflow

1 parent1f678c4 commita3e6421Copy full SHA for a3e6421

File tree

1 file changed

-1

lines changed

src/main/java/com/ning/http/client/multipart
- FilePart.java

1 file changed

-1

lines changed

`‎src/main/java/com/ning/http/client/multipart/FilePart.java‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public long write(WritableByteChannel target, byte[] boundary) throws IOExceptio`
`101`	`101`
`102`	`102`	`handler.start();`
`103`	`103`
`104`		`-intlength =0;`
	`104`	`+longlength =0;`
`105`	`105`
`106`	`106`	`length +=MultipartUtils.writeBytesToChannel(target,generateFileStart(boundary));`
`107`	`107`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita3e6421

File tree

1 file changed

1 file changed

`‎src/main/java/com/ning/http/client/multipart/FilePart.java‎`

0 commit comments