Commita0e60a5

committed

Provide original WebSocket exception instead of cause,closeAsyncHttpClient#1392

Motivation:The WebSocketHandler notifies the WebSocket with the cause Exception.This way loses information, and cause might be null.Mofivivation:Propagate original exceptionResult:User has more information about the crash

1 parent9a6a8ae commita0e60a5Copy full SHA for a0e60a5

File tree

1 file changed

-1

lines changed

client/src/main/java/org/asynchttpclient/netty/handler
- WebSocketHandler.java

1 file changed

-1

lines changed

`‎client/src/main/java/org/asynchttpclient/netty/handler/WebSocketHandler.java‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ public void handleException(NettyResponseFuture<?> future, Throwable e) {`
`148`	`148`	`try {`
`149`	`149`	`NettyWebSocketwebSocket =getNettyWebSocket(future);`
`150`	`150`	`if (webSocket !=null) {`
`151`		`-webSocket.onError(e.getCause());`
	`151`	`+webSocket.onError(e);`
`152`	`152`	`webSocket.sendCloseFrame();`
`153`	`153`	`}`
`154`	`154`	`}catch (Throwablet) {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita0e60a5

File tree

1 file changed

1 file changed

`‎client/src/main/java/org/asynchttpclient/netty/handler/WebSocketHandler.java‎`

0 commit comments