Commit475c599

Stephane Landelle

committed

Setting a Realm shouldn't override existing Authentication headers,closeAsyncHttpClient#448

1 parent16fa2d8 commit475c599Copy full SHA for 475c599

File tree

1 file changed

-4

lines changed

src/main/java/com/ning/http/client/providers/netty
- NettyAsyncHttpProvider.java

1 file changed

-4

lines changed

`‎src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -703,20 +703,20 @@ else if (uri.getRawQuery() != null)`
`703`	`703`
`704`	`704`	`switch (realm.getAuthScheme()) {`
`705`	`705`	`caseBASIC:`
`706`		`-nettyRequest.setHeader(HttpHeaders.Names.AUTHORIZATION,AuthenticatorUtils.computeBasicAuthentication(realm));`
	`706`	`+nettyRequest.addHeader(HttpHeaders.Names.AUTHORIZATION,AuthenticatorUtils.computeBasicAuthentication(realm));`
`707`	`707`	`break;`
`708`	`708`	`caseDIGEST:`
`709`	`709`	`if (isNonEmpty(realm.getNonce())) {`
`710`	`710`	`try {`
`711`		`-nettyRequest.setHeader(HttpHeaders.Names.AUTHORIZATION,AuthenticatorUtils.computeDigestAuthentication(realm));`
	`711`	`+nettyRequest.addHeader(HttpHeaders.Names.AUTHORIZATION,AuthenticatorUtils.computeDigestAuthentication(realm));`
`712`	`712`	`}catch (NoSuchAlgorithmExceptione) {`
`713`	`713`	`thrownewSecurityException(e);`
`714`	`714`	`}`
`715`	`715`	`}`
`716`	`716`	`break;`
`717`	`717`	`caseNTLM:`
`718`	`718`	`try {`
`719`		`-nettyRequest.setHeader(HttpHeaders.Names.AUTHORIZATION,ntlmEngine.generateType1Msg("NTLM " +domain,authHost));`
	`719`	`+nettyRequest.addHeader(HttpHeaders.Names.AUTHORIZATION,ntlmEngine.generateType1Msg("NTLM " +domain,authHost));`
`720`	`720`	`}catch (NTLMEngineExceptione) {`
`721`	`721`	`IOExceptionie =newIOException();`
`722`	`722`	`ie.initCause(e);`
`@@ -734,7 +734,7 @@ else if (uri.getRawQuery() != null)`
`734`	`734`	`ie.initCause(e);`
`735`	`735`	`throwie;`
`736`	`736`	`}`
`737`		`-nettyRequest.setHeader(HttpHeaders.Names.AUTHORIZATION,"Negotiate " +challengeHeader);`
	`737`	`+nettyRequest.addHeader(HttpHeaders.Names.AUTHORIZATION,"Negotiate " +challengeHeader);`
`738`	`738`	`break;`
`739`	`739`	`caseNONE:`
`740`	`740`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit475c599

File tree

1 file changed

1 file changed

`‎src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java‎`

0 commit comments