Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add topclaudy/compoships support#1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alruhmi wants to merge1 commit intobarryvdh:master
base:master
Choose a base branch
Loading
fromalruhmi:compoships-support

Conversation

@alruhmi
Copy link

Summary

supporttopclaudy/compoships by adding check in methodModelsCommand::isRelationNullable().

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed viacomposer fix-style

@mfn
Copy link
Collaborator

mfn commentedFeb 27, 2022

Is there a way to avoid having this directly in the library? Like, using hooks or making the code more open/extendable so this can be maintained outside?

Why?

It's already not easy to handle all the variants you can with models just with laravel and multiple versions and on top of that supporting 3rd, no matter how popular, won't make it easier and it's prune to break stuff. Also it makes the code harder to reason for things barely used.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alruhmi@mfn
[8]ページ先頭
©2009-2025 Movatter.jp