Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[babel 8] Deprecate uppercase builders#17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nicolo-ribaudo
Copy link
Member

Q                      A
Fixed Issues?Closes#17129
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?Yes
Documentation PR Link
Any Dependency Changes?
LicenseMIT

@nicolo-ribaudonicolo-ribaudo added the PR: Deprecation (next major) 📢A type of pull request used for our changelog categories for next major release labelFeb 14, 2025
@nicolo-ribaudonicolo-ribaudo marked this pull request as draftFebruary 14, 2025 11:39
@nicolo-ribaudo
Copy link
MemberAuthor

Marking as draft until when I add a test

@babel-bot
Copy link
Collaborator

babel-bot commentedFeb 14, 2025•
edited
Loading

Build successful! You can test your changes in the REPL here:https://babeljs.io/repl/build/58929

@nicolo-ribaudonicolo-ribaudo changed the title[babel 8] Deprecate uppercase builders[babel 8] Deprecate uppercase builders, and remove deprecated onesFeb 14, 2025
@nicolo-ribaudonicolo-ribaudo changed the title[babel 8] Deprecate uppercase builders, and remove deprecated ones[babel 8] Deprecate uppercase buildersFeb 14, 2025
@nicolo-ribaudonicolo-ribaudoforce-pushed theuppercase-builders-deprecate branch fromca09cf0 to76c9f7bCompareMarch 21, 2025 11:35
@nicolo-ribaudonicolo-ribaudo marked this pull request as ready for reviewMarch 21, 2025 11:38
@nicolo-ribaudonicolo-ribaudoforce-pushed theuppercase-builders-deprecate branch from0a81046 to27f28c2CompareMarch 24, 2025 17:40
@nicolo-ribaudonicolo-ribaudoforce-pushed theuppercase-builders-deprecate branch from27f28c2 toe17cf27CompareMarch 24, 2025 18:10
@liuxingbaoyu
Copy link
Member

Would it be better to only warn once for the uppercase builder?
I'm concerned about having a few different nodes causing too many warnings to be output.

JLHwung reacted with thumbs up emoji

@nicolo-ribaudo
Copy link
MemberAuthor

nicolo-ribaudo commentedMar 24, 2025•
edited
Loading

You mean once per builder, or once in general for all builders?

@liuxingbaoyu
Copy link
Member

liuxingbaoyu commentedMar 24, 2025•
edited
Loading

Once in general for all builders, but it would be better to keep the specific node names. :)

Maybe add acacheKey parameter todeprecationWarning.

@nicolo-ribaudonicolo-ribaudo merged commit0d098d7 intobabel:mainMar 26, 2025
55 checks passed
@nicolo-ribaudonicolo-ribaudo deleted the uppercase-builders-deprecate branchMarch 26, 2025 14:25
@github-actionsgithub-actionsbot added the outdatedA closed issue/PR that is archived due to age. Recommended to make a new issue labelJun 26, 2025
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JLHwungJLHwungJLHwung approved these changes

@liuxingbaoyuliuxingbaoyuliuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdatedA closed issue/PR that is archived due to age. Recommended to make a new issuePR: Deprecation (next major) 📢A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate uppercase builders?
4 participants
@nicolo-ribaudo@babel-bot@liuxingbaoyu@JLHwung
[8]ページ先頭
©2009-2025 Movatter.jp