Summary

This PR will add additional unit testing for the network fault injection handlers, specifically the ordering of when each request finishes if they're modifying the same resource (e.g. the same network namespace/network interface).

The ordering/workflow is the following:

• Make an asynchronous start fault request that takes some time to finish and starts being handled
• Make an asynchronous stop fault request that does not take any time to finish and waits until the start fault finishes being handled
• Both requests should be successful

Implementation details

• makeAsyncRequest() : Helper function that is called upon in a goroutine to make mock HTTP requests
• New tests cases added inTestNetworkFaultRequestOrdering(): The test cases will make two sequential asynchronous HTTP request (1 start and then 1 stop fault request). We will be mocking the first request (start fault) to be taking some time to finish while the second request (stop fault) should wait until the first request finishes before it gets executed.

Testing

New test cases that were introduced:

• Make 1 asynchronous start black hole port fault request and then 1 asynchronous stop black hole port request
• Make 1 asynchronous start latency fault request and then 1 asynchronous stop latency request
• Make 1 asynchronous start packet loss fault request and then 1 asynchronous stop packet loss request

New tests cover the changes: yes

Description for the changelog

Feature: Adding network fault request ordering unit test cases

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.