Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Partitioning: Initial suggestion#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
m0rt3nlund wants to merge12 commits intoash-project:main
base:main
Choose a base branch
Loading
fromm0rt3nlund:Partitioning-support

Conversation

@m0rt3nlund
Copy link
Contributor

Hi!

This is my initial suggestion to include "partitioning" support.
Feedback is appreciated!

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@m0rt3nlundm0rt3nlund changed the titleInitial suggestionPartitioning: Initial suggestionFeb 14, 2025
@zachdaniel
Copy link
Contributor

The general pattern looks good, although there will be some details to talk through and some docs about how to manage partitions, maybe some builtin changes to do it automatically etc. The migration generator is going to have to have some kind of handling for changing the partition strategy as well.

I noticed some unfinished bits as well, i.e for creating range partitions. We should definitely avoid the string interpolation in the SQL there as well.

@m0rt3nlundm0rt3nlund marked this pull request as draftFebruary 17, 2025 12:24
@m0rt3nlund
Copy link
ContributorAuthor

I made some updates before reading your comments.
I will try to make a new draft considering your comments :)

@m0rt3nlund
Copy link
ContributorAuthor

Also found some problems when updating the primary key on multitenancy resource.
Not sure it this is how you would prefer to fix it.

@zachdaniel
Copy link
Contributor

Could we separate out that other fix that you mentioned into its own PR so that I can review in isolation?

m0rt3nlund reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zachdanielzachdanielzachdaniel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m0rt3nlund@zachdaniel

[8]ページ先頭

©2009-2025 Movatter.jp