Commit702aba7

committed

Always user iterator for commits

based on feedback from sigmavirus24 in issuesigmavirus24#1137

1 parentdad2dcc commit702aba7Copy full SHA for 702aba7

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,13 +66,7 @@ def _update_attributes(self, compare):`
`66`	`66`	`self.behind_by=compare["behind_by"]`
`67`	`67`	`self.commits=compare["commits"]`
`68`	`68`	`self.total_commits=compare["total_commits"]`
`69`		`-ifself.commits:`
`70`		`-ifself.total_commits>len(self.commits):`
`71`		`-self.commits=self._iter(-1,self._api,commit.ShortCommit,list_key="commits")`
`72`		`-else:`
`73`		`-self.commits= [`
`74`		`-commit.ShortCommit(com,self)forcominself.commits`
`75`		`- ]`
	`69`	`+self.commits=self._iter(-1,self._api,commit.ShortCommit,list_key="commits")`
`76`	`70`	`self.diff_url=compare["diff_url"]`
`77`	`71`	`self.files=compare["files"]`
`78`	`72`	`self.html_url=compare["html_url"]`

Comments

(0)