- Notifications
You must be signed in to change notification settings - Fork229
Mixed naming of central and peripheral in examples#232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mklemarczyk wants to merge1 commit intoarduino-libraries:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Mixed naming of central and peripheral in examples#232
mklemarczyk wants to merge1 commit intoarduino-libraries:masterfrommklemarczyk:hotfix/example-variable-naming
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixed the names and comments to not confuse the users.
ContributorAuthor
mklemarczyk commentedJun 24, 2022
What I can do to accelerate approval of that PR ? |
ContributorAuthor
mklemarczyk commentedSep 14, 2022
@facchinm You do not want this change? There are several PRs waiting, and no comment or merged. |
ContributorAuthor
mklemarczyk commentedJun 11, 2023
Bump, any answer on the integration ? I wonder why it takes so long... |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: documentationRelated to documentation for the project type: imperfectionPerceived defect in any part of project
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the names and comments to not confuse the users.
The BLE central can start connection to peripheral, not vice versa.
The most confusing one was that we wait for peripherals to connect, and next comment name the variable that it is central. :)