Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use golangci-lint instead of golint#778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
per1234 wants to merge1 commit intoarduino:main
base:main
Choose a base branch
Loading
fromper1234:golangci-lint

Conversation

@per1234
Copy link
Contributor

golint has been deprecated.

golint has been deprecated.
@per1234per1234 added type: enhancementProposed improvement topic: infrastructureRelated to project infrastructure labelsOct 15, 2024
@per1234per1234 self-assigned thisOct 15, 2024
@codecov
Copy link

codecovbot commentedOct 15, 2024
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (b9f5a82) to head (6bf30f3).
⚠️ Report is 431 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main     #778   +/-   ##=======================================  Coverage   90.05%   90.05%           =======================================  Files          44       44             Lines        6800     6800           =======================================  Hits         6124     6124             Misses        553      553             Partials      123      123
FlagCoverage Δ
unit90.05% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
ContributorAuthor

@per1234per1234 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The codebase produces many linting errors fromgolangci-lint, even though it was passinggolint. I think this should be put on hold until#761 is merged as the fixes for the linting errors might cause merge conflicts with the work done in that PR.

@per1234per1234 added the status: blockedProgress on this prevented by an external cause labelOct 16, 2024
@per1234per1234 added status: changes requestedChanges to PR are required before merge and removed status: blockedProgress on this prevented by an external cause labelsNov 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@per1234per1234

Labels

status: changes requestedChanges to PR are required before mergetopic: infrastructureRelated to project infrastructuretype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@per1234

[8]ページ先頭

©2009-2025 Movatter.jp