Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork12
Bump go.bug.st/relaxed-semver from 0.11.0 to 0.12.0#645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
per1234 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe the errors exposed by the CI are caused by thego.bug.st/relaxed-semver module's use of features that are not available in the 1.17 version of Go currently used with this project. The module now specifies minimum compatibility of Go 1.21:bugst/relaxed-semver#18.
So merging of this PR must be put on hold until we are able to find time to update the project to using a newer version of Go.
per1234 commentedNov 25, 2024
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
per1234 commentedNov 25, 2024
@dependabot recreate |
a3c12c7 tob1d10f1Compareper1234 commentedNov 25, 2024
@dependabot rebase |
b1d10f1 to2694b1aCompareper1234 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The previous blocker ofgo.bug.st/relaxed-semver@v0.12.0 requiring a higher version of Go than used by this project has been resolved by#761.
Unfortunately there is an additional blocker, as revealed bytask go:vet:
https://github.com/arduino/arduino-lint/actions/runs/12005234943/job/33461512685?pr=645#step:5:19
Error: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.20241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:151:28: cannot use generic type semver.Releases[R semver.Release[D], D semver.Dependency] without instantiationError: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.20241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:153:15: cannot use generic type semver.Releases[R semver.Release[D], D semver.Dependency] without instantiationError: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.[20](https://github.com/arduino/arduino-lint/actions/runs/12005234943/job/33461512685?pr=645#step:5:21)241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:161:21: undefined: semver.Archivetask: Failed to run task "go:vet": exit status 1Error: Process completed with exit code 201.So thev0.35.4-0.20241001142927-1f8d0f6c0dd3 version of thegithub.com/arduino/arduino-cli dependency is incompatible withgo.bug.st/relaxed-semver@v0.12.0, due to breaking changes in thego.bug.st/relaxed-semver API. This means that thegithub.com/arduino/arduino-cli dependency must be bumped in tandem with thego.bug.st/relaxed-semver bump proposed here.
github.com/arduino/arduino-cli was updated to use thego.bug.st/relaxed-semver@v0.12.0 API inarduino/arduino-cli@0381aa5, which was released ingithub.com/arduino/arduino-cli@v1.0.0. Significant changes were introduced to thegithub.com/arduino/arduino-cli API in v1.0.0, which include making most of its packagesinternal. So significant changes to the Arduino Lint codebase are likely to be required in order to bumpgithub.com/arduino/arduino-cli to >=v1.0.0.
A newer version of go.bug.st/relaxed-semver exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
per1234 commentedApr 11, 2025
@dependabot recreate |
Bumps [go.bug.st/relaxed-semver](https://github.com/bugst/relaxed-semver) from 0.11.0 to 0.12.0.- [Release notes](https://github.com/bugst/relaxed-semver/releases)- [Commits](bugst/relaxed-semver@v0.11.0...v0.12.0)---updated-dependencies:- dependency-name: go.bug.st/relaxed-semver dependency-type: direct:production update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
04bc9db to14179a9CompareSuperseded by#864. |
Uh oh!
There was an error while loading.Please reload this page.
Bumpsgo.bug.st/relaxed-semver from 0.11.0 to 0.12.0.
Release notes
Sourced fromgo.bug.st/relaxed-semver's releases.
Commits
b4bf3c6Merge pull request#17 from bugst/performance391e859Merge pull request#19 from bugst/templated_resolverfee3392Fixed another bug in comparator89efb15Fixed JSON/YAML/Binary parsingae9c7bacoverage to 100% againa325c52Made Resolver state variables as fields00b3516Simplified loop8711f89Renamed Archive -> Resolver9f1049eImplemented dependency-templated resolvere8b9735Merge pull request#18 from bugst/go1.21You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)