Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump github.com/ory/jsonschema/v3 from 3.0.4 to 3.0.8#522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dependabot wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromdependabot/go_modules/github.com/ory/jsonschema/v3-3.0.8

Conversation

@dependabot
Copy link
Contributor

@dependabotdependabotbot commented on behalf ofgithubApr 5, 2023
edited
Loading

Bumpsgithub.com/ory/jsonschema/v3 from 3.0.4 to 3.0.8.

Release notes

Sourced fromgithub.com/ory/jsonschema/v3's releases.

v3.0.8

What's Changed

Full Changelog:ory/jsonschema@v3.0.7...v3.0.8

v3.0.7

Full Changelog:ory/jsonschema@v3.0.6...v3.0.7

v3.0.6

No release notes provided.

v3.0.5

No release notes provided.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting@dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note**> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/ory/jsonschema/v3](https://github.com/ory/jsonschema) from 3.0.4 to 3.0.8.- [Release notes](https://github.com/ory/jsonschema/releases)- [Commits](ory/jsonschema@v3.0.4...v3.0.8)---updated-dependencies:- dependency-name: github.com/ory/jsonschema/v3  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotbot added the topic: infrastructureRelated to project infrastructure labelApr 5, 2023
@per1234per1234 added the status: on holdDo not proceed at this time labelMay 11, 2023
Copy link
Contributor

@per1234per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A major breaking change was made to the API of this module and then released with only a patch version bump (v3.0.4 -> v3.0.5).

When I asked about this, I received this response:

ory/jsonschema#8 (comment)

Yes, we only use this fork internally though. I'd recommend using the upstream for anyone else

Since the current version of the dependency works fine, it doesn't seem worth the effort to port the code to accommodate the breaking change. It would be better to invest the development resources to replacing this dependency that is not being maintained in a reliable manner (or perhaps to abandoning the too limiting schema-based approach completely).

I thoroughly evaluated all the available Go modules for JSON schema validation during the initial development of Arduino Lint. Most were not at all suitable because they only provide human readable validation output. Arduino Lint requires machine consumable output which can then be interpreted according to the current tool settings and translated to user friendly error and warning messages.

The only module I found that met this requirement was:
https://github.com/santhosh-tekuri/jsonschema
However, I found even it did not provide sufficient machine consumable output under certain schema configurations. Another user had previously encountered this issue andcreated a fork when the main module's maintainer was not receptive tothe proposal. So I used that fork.

It would be worth checking to see if it would now be possible to switch from usinggithub.com/ory/jsonschema to the properly maintained upstreamgithub.com/santhosh-tekuri/jsonschema. There has been quite a lot of development in that module since the time I evaluated it, so maybe the needed capability has been added.

An alternative solution would be to configure the schemas in such a manner as to avoid the limitation that caused me to rejectgithub.com/santhosh-tekuri/jsonschema originally. I think that is possible, but it makes them much more difficult to develop, maintain, and contribute to. The main benefit to the JSON schema-based approach is standardization, so we lose some of that by not providing full compatibility.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@per1234per1234per1234 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@per1234per1234

Labels

status: on holdDo not proceed at this timetopic: infrastructureRelated to project infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@per1234

[8]ページ先頭

©2009-2025 Movatter.jp