Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite2ee58f

Browse files
committed
Fix collision between macOS workflow artifacts in release workflows
GitHub Workflows are used to automatically generate and publish production and nightly releases of the project. This isdone for a range of host architectures, including macOS. The macOS builds are then put through a notarization process ina dedicated workflow job.GitHub Actions workflow artifacts are used to transfer the generated files between sequential jobs in the workflow. The"actions/upload-artifact" and "actions/download-artifact" actions are used for this purpose.The workflow artifact handling had to be reworked recently in order to handle a breaking change in the 4.0.0 release ofthe "actions/upload-artifact" action. Previously, a single artifact was used for the transfer of the builds for allhosts. However, support for uploading multiple times to a single artifact was dropped in version 4.0.0 of the"actions/upload-artifact" action. So it is now necessary to use a dedicated artifact for each of the builds. These aredownloaded in aggregate in a subsequent job by using the artifact name globbing and merging features which wereintroduced in version 4.1.0 of the "actions/download-artifact" action.A regression was introduced at that time. The chosen approach was to use a separate set of artifacts for thenon-notarized and notarized files. An overview of the sequence (the prefixes are the workflow job names):1. create-release-artifacts/create-nightly-artifacts: Generate builds.2. create-release-artifacts/create-nightly-artifacts: Upload builds to workflow artifacts3. notarize-macos: Download workflow artifacts.4. notarize-macos: Notarize macOS build from downloaded artifact.5. notarize-macos: Upload notarized build to workflow artifact with a different name than the source artifact.6. create-release/publish-nightly: Download workflow artifacts.7. create-release/publish-nightly: Publish builds.The problem with this is that the artifacts for the non-notarized (uploaded by thecreate-release-artifacts/create-nightly-artifacts job) and notarized (created by the notarize-macos job) files are thendownloaded and merged by the create-release/publish-nightly job. Since each artifact contains a file with the same pathin the merged output, the contents of the last downloaded artifact overwrite the contents of the first. It happens thatthe non-notarized artifact is downloaded after the notarized artifact, so this file path collision results innon-notarized macOS builds being published instead of the notarized builds as intended, and as done by the workflowprior to the regression. For example, this bug was also present in the Arduino CLI repository and you can see the impacton its releases:```% wgethttps://downloads.arduino.cc/arduino-cli/nightly/arduino-cli_nightly-latest_macOS_ARM64.tar.gz[...]% tar -xf arduino-cli_nightly-latest_macOS_ARM64.tar.gz% spctl -a -vvv -t install arduino-cliarduino-cli: rejected``````% wgethttps://downloads.arduino.cc/arduino-cli/arduino-cli_latest_macOS_ARM64.tar.gz[..]% tar -xf arduino-cli_latest_macOS_ARM64.tar.gz% spctl -a -vvv -t install arduino-cliarduino-cli: rejected```The chosen solution is that, instead of using new artifacts for the notarized builds, to overwrite the same macOSartifacts containing the no-notarized builds, which were generated by thecreate-release-artifacts/create-nightly-artifacts job with the notarized builds from the notarize-macos jobs. This ismade possible by the overwriting capability of the "actions/upload-artifact" action (which was introduced in version4.2.0).An overview of the new sequence (the prefixes are the workflow job names):1. create-release-artifacts/create-nightly-artifacts: Generate builds.2. create-release-artifacts/create-nightly-artifacts: Upload builds to workflow artifacts3. notarize-macos: Download macOS x86 or Apple Silicon workflow artifact.5. notarize-macos: Notarize macOS build from downloaded artifact.6. notarize-macos: Upload notarized build to same workflow artifact, overwriting the non-notarized contents.7. create-release/publish-nightly: Download workflow artifacts.8. create-release/publish-nightly: Publish builds.
1 parent4973a41 commite2ee58f

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

‎.github/workflows/publish-go-nightly-task.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ jobs:
8181
strategy:
8282
matrix:
8383
build:
84-
-folder-suffix:darwin_amd64
84+
-artifact-suffix:macOS_64bit
85+
folder-suffix:darwin_amd64
8586
package-suffix:"macOS_64bit.tar.gz"
86-
-folder-suffix:darwin_arm64
87+
-artifact-suffix:macOS_ARM64
88+
folder-suffix:darwin_arm64
8789
package-suffix:"macOS_ARM64.tar.gz"
8890

8991
steps:
@@ -172,11 +174,12 @@ jobs:
172174
-C ../../ LICENSE.txt
173175
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
174176
175-
-name:Upload artifact
177+
-name:Replace artifact with notarized build
176178
uses:actions/upload-artifact@v4
177179
with:
178180
if-no-files-found:error
179-
name:${{ env.ARTIFACT_PREFIX }}notarized-${{ matrix.build.folder-suffix }}
181+
name:${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
182+
overwrite:true
180183
path:${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
181184

182185
publish-nightly:

‎.github/workflows/release-go-task.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ jobs:
8888
strategy:
8989
matrix:
9090
build:
91-
-folder-suffix:darwin_amd64
91+
-artifact-suffix:macOS_64bit
92+
folder-suffix:darwin_amd64
9293
package-suffix:"macOS_64bit.tar.gz"
93-
-folder-suffix:darwin_arm64
94+
-artifact-suffix:macOS_ARM64
95+
folder-suffix:darwin_arm64
9496
package-suffix:"macOS_ARM64.tar.gz"
9597

9698
steps:
@@ -178,11 +180,12 @@ jobs:
178180
-C "${{ env.BUILD_FOLDER }}/" "${{ env.PROJECT_NAME }}" \
179181
-C ../../ LICENSE.txt
180182
181-
-name:Upload artifact
183+
-name:Replace artifact with notarized build
182184
uses:actions/upload-artifact@v4
183185
with:
184186
if-no-files-found:error
185-
name:${{ env.ARTIFACT_PREFIX }}notarized-${{ matrix.build.folder-suffix }}
187+
name:${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
188+
overwrite:true
186189
path:${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
187190

188191
create-release:

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp